commit 8b5c6740fb89ba64b316abc0113267075dad515c
author Shunkai Yao <yaoshunkai@google.com> Fri Apr 07 22:35:10 2023 +0000
committer Shunkai Yao <yaoshunkai@google.com> Fri Apr 07 22:37:21 2023 +0000
tree 5b41c0886cc304e9a65729969485d925c0b65837
parent df5c0f59449f1f31f6cd83c3ec60046a536cd255

Fix the error with EffectProxy open

Bug: 261129656
Test: Enable AIDL and test with Pixel
Change-Id: Ic1435a857cc336a01934e5cc21938892e1df2fef

media/libaudiohal/impl/EffectProxy.cpp

diff --git a/media/libaudiohal/impl/EffectProxy.cpp b/media/libaudiohal/impl/EffectProxy.cpp
index c4d85e5..b61532d 100644
--- a/media/libaudiohal/impl/EffectProxy.cpp
+++ b/media/libaudiohal/impl/EffectProxy.cpp
@@ -158,8 +158,7 @@
     for (auto& sub : mSubEffects) {
         auto& effect = std::get<SubEffectTupleIndex::HANDLE>(sub.second);
         auto& openRet = std::get<SubEffectTupleIndex::RETURN>(sub.second);
-        if (!effect ||
-            (status = effect->open(common, specific, &openRet)).isOk()) {
+        if (!effect || !(status = effect->open(common, specific, &openRet)).isOk()) {
             ALOGE("%s: failed to open UUID %s", __func__, sub.first.uuid.toString().c_str());
             break;
         }