commit 8b0b971b1416738f22488a80be726d1ec12552a8
author Chih-Hung Hsieh <chh@google.com> Tue Aug 09 14:25:53 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Tue Aug 09 16:24:09 2016 -0700
tree e095c435db1050ef5fbbfaef3994638d0248870f
parent 9831a9b576fb8d58c3e8057086b5263f139cf4b9

Fix clang-tidy warnings in camera.

* Add explicit keyword to conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1

Change-Id: I71d3008da843ba5f1df1a73a320fb2af6ceffa16

services/camera/libcameraservice/CameraService.h

diff --git a/services/camera/libcameraservice/CameraService.h b/services/camera/libcameraservice/CameraService.h
index 4332ce3..b35f35c 100644
--- a/services/camera/libcameraservice/CameraService.h
+++ b/services/camera/libcameraservice/CameraService.h
@@ -265,7 +265,7 @@
 
         class OpsCallback : public BnAppOpsCallback {
         public:
-            OpsCallback(wp<BasicClient> client);
+            explicit OpsCallback(wp<BasicClient> client);
             virtual void opChanged(int32_t op, const String16& packageName);
 
         private: