commit 8ade257ef06ec593f0bf17440cbf57bdd591d8b1
author Shunkai Yao <yaoshunkai@google.com> Fri Jul 28 00:55:00 2023 +0000
committer Shunkai Yao <yaoshunkai@google.com> Fri Jul 28 01:34:01 2023 +0000
tree 44db54a8ab918cce713eecda825705ce274a0766
parent 57c8ffbc72511b696420a7ffa95aa39f2dc74b50

Validate IAfEffectHandle before access virtual methods

Bug: 290218127
Test: atest DeviceEffectTest#testIsEffectSupportedForDevice --iterations 50
Change-Id: I2e427a80e19c2e5987673bfd014a5da5566f4a24

services/audioflinger/AudioFlinger.cpp

diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp
index 1e59bf8..22358db 100644
--- a/services/audioflinger/AudioFlinger.cpp
+++ b/services/audioflinger/AudioFlinger.cpp
@@ -4314,7 +4314,7 @@
 
     response->id = idOut;
     response->enabled = enabledOut != 0;
-    response->effect = handle->asIEffect();
+    response->effect = handle.get() ? handle->asIEffect() : nullptr;
     response->desc = VALUE_OR_RETURN_STATUS(
             legacy2aidl_effect_descriptor_t_EffectDescriptor(descOut));