commit 82e14cda5c0422761821a1d4a4ace26e12d247ba
author Kevin Rocard <krocard@google.com> Fri Mar 30 10:09:42 2018 -0700
committer Kevin Rocard <krocard@google.com> Fri Mar 30 17:11:41 2018 +0000
tree e8009e74c4fe37625e9551fc1a10d238a88264b5
parent 83028d5920884992b16f34aca167cd6c27734d3c

Invalid audio effect config could crash the parser

Due to a typo in an error message.

Bug: 74446193
Test: boot
Change-Id: Ief4150ff335e53c7b08bbc9ec9fd20ee61d4e13a
Signed-off-by: Kevin Rocard <krocard@google.com>

media/libeffects/config/src/EffectsConfig.cpp

diff --git a/media/libeffects/config/src/EffectsConfig.cpp b/media/libeffects/config/src/EffectsConfig.cpp
index 4ed3ba8..d79501f 100644
--- a/media/libeffects/config/src/EffectsConfig.cpp
+++ b/media/libeffects/config/src/EffectsConfig.cpp
@@ -203,7 +203,7 @@
         auto parseProxy = [&xmlEffect, &parseImpl](const char* tag, EffectImpl& proxyLib) {
             auto* xmlProxyLib = xmlEffect.FirstChildElement(tag);
             if (xmlProxyLib == nullptr) {
-                ALOGE("effectProxy must contain a <%s>: %s", tag, dump(*xmlProxyLib));
+                ALOGE("effectProxy must contain a <%s>: %s", tag, dump(xmlEffect));
                 return false;
             }
             return parseImpl(*xmlProxyLib, proxyLib);