commit 7fd5bdb5fa9db81f0293793b7b6d45dd833d05b2
author Yunlian Jiang <yunlian@google.com> Tue Nov 22 15:16:25 2016 -0800
committer Yunlian Jiang <yunlian@google.com> Wed Nov 23 00:06:49 2016 +0000
tree 66c902ca2180a1ad6289d85ecb250d46fd838abe
parent bd54eef2d289f786a7ae02139ce3bb9db2b03b24

fix warning The left operand of '!=' is a garbage value

The 'res' is  uninitialized if params.state == Parameters::PREVIEW.
This sets the default value to 'OK' to silence this warning.

Bug: None
Test: Run clang-tidy on this code and the warning is gone.
Change-Id: I9d1b5e09c7957813f3c66d052c6a9f7d4b074b84

services/camera/libcameraservice/api1/Camera2Client.cpp

diff --git a/services/camera/libcameraservice/api1/Camera2Client.cpp b/services/camera/libcameraservice/api1/Camera2Client.cpp
index bcd62d6..bfbf640 100644
--- a/services/camera/libcameraservice/api1/Camera2Client.cpp
+++ b/services/camera/libcameraservice/api1/Camera2Client.cpp
@@ -993,7 +993,7 @@
 }
 
 status_t Camera2Client::startRecordingL(Parameters &params, bool restart) {
-    status_t res;
+    status_t res = OK;
 
     ALOGV("%s: state == %d, restart = %d", __FUNCTION__, params.state, restart);