commit 7cd1b2b372a849fcf3f2951ee1da55fa574d95b3
author Kim Sungyeon <sy85.kim@samsung.com> Thu Jul 05 22:22:07 2018 +0900
committer Lajos Molnar <lajos@google.com> Wed Feb 17 08:32:58 2021 -0800
tree 82f69a7d3e8b485ddaaa2fa7471f843320ea08bd
parent d3dba6982270cd889353d32a33b72e23f63b5b23

VT: Add OMX_Video_ControlRateConstant feature

The OMX_Video_ControlRateConstant is a sutiable OMX option
to stablize encoder bandwidth.

This helps encoder to make more regular bps.

Merged-in: I67a08be8b8a19b573c873e96d317e16c7105084e
Change-Id: I67a08be8b8a19b573c873e96d317e16c7105084e
Signed-off-by: Kim Sungyeon <sy85.kim@samsung.com>

media/libmediaplayerservice/StagefrightRecorder.cpp

diff --git a/media/libmediaplayerservice/StagefrightRecorder.cpp b/media/libmediaplayerservice/StagefrightRecorder.cpp
index 8b4e2ed..31a0695 100644
--- a/media/libmediaplayerservice/StagefrightRecorder.cpp
+++ b/media/libmediaplayerservice/StagefrightRecorder.cpp
@@ -589,6 +589,16 @@
     return OK;
 }
 
+status_t StagefrightRecorder::setParamVideoBitRateMode(int32_t bitRateMode) {
+    ALOGV("setParamVideoBitRateMode: %d", bitRateMode);
+    if (bitRateMode < -1) {
+        ALOGE("Unsupported video bitrate mode: %d", bitRateMode);
+        return BAD_VALUE;
+    }
+    mVideoBitRateMode = bitRateMode;
+    return OK;
+}
+
 // Always rotate clockwise, and only support 0, 90, 180 and 270 for now.
 status_t StagefrightRecorder::setParamVideoRotation(int32_t degrees) {
     ALOGV("setParamVideoRotation: %d", degrees);
@@ -945,6 +955,11 @@
         if (safe_strtoi32(value.string(), &video_bitrate)) {
             return setParamVideoEncodingBitRate(video_bitrate);
         }
+    } else if (key == "video-param-bitrate-mode") {
+        int32_t video_bitrate_mode;
+        if (safe_strtoi32(value.string(), &video_bitrate_mode)) {
+            return setParamVideoBitRateMode(video_bitrate_mode);
+        }
     } else if (key == "video-param-rotation-angle-degrees") {
         int32_t degrees;
         if (safe_strtoi32(value.string(), &degrees)) {
@@ -1930,6 +1945,8 @@
     }
 
     format->setInt32("bitrate", mVideoBitRate);
+    // OMX encoder option how to control bitrate
+    format->setInt32("bitrate-mode", mVideoBitRateMode);
     format->setInt32("frame-rate", mFrameRate);
     format->setInt32("i-frame-interval", mIFramesIntervalSec);
 
@@ -2352,6 +2369,8 @@
     mVideoHeight   = 144;
     mFrameRate     = -1;
     mVideoBitRate  = 192000;
+    // Following ACodec's default
+    mVideoBitRateMode = OMX_Video_ControlRateVariable;
     mSampleRate    = 8000;
     mAudioChannels = 1;
     mAudioBitRate  = 12200;

media/libmediaplayerservice/StagefrightRecorder.h

diff --git a/media/libmediaplayerservice/StagefrightRecorder.h b/media/libmediaplayerservice/StagefrightRecorder.h
index c2638cd..02300a0 100644
--- a/media/libmediaplayerservice/StagefrightRecorder.h
+++ b/media/libmediaplayerservice/StagefrightRecorder.h
@@ -119,6 +119,7 @@
     int32_t mVideoWidth, mVideoHeight;
     int32_t mFrameRate;
     int32_t mVideoBitRate;
+    int32_t mVideoBitRateMode;
     int32_t mAudioBitRate;
     int32_t mAudioChannels;
     int32_t mSampleRate;
@@ -215,6 +216,7 @@
     status_t setParamCaptureFpsEnable(int32_t timeLapseEnable);
     status_t setParamCaptureFps(double fps);
     status_t setParamVideoEncodingBitRate(int32_t bitRate);
+    status_t setParamVideoBitRateMode(int32_t bitRateMode);
     status_t setParamVideoIFramesInterval(int32_t seconds);
     status_t setParamVideoEncoderProfile(int32_t profile);
     status_t setParamVideoEncoderLevel(int32_t level);