commit 7bc710b932e81c9662b3ea2e243dbc08e454d0cc
author Phil Burk <philburk@google.com> Thu Sep 01 16:57:00 2022 +0000
committer Phil Burk <philburk@google.com> Thu Sep 01 20:44:59 2022 +0000
tree e20fa7dc3ac791f6d8aaa3ce91c0a80c0cf5ed5a
parent 54c39be8cb6c867528f201e4fc671c16b5f7548d

aaudio: preserve requested device ID, fix regression

This fixes a bug that caused the mDeviceId and the mRequestedDeviceId
to be set to a specific device even when UNSPECIFIED was requested.
That led to some streams not getting disconnected when they should.

Bug: 242648766
Test: OboeTester TEST DISCONNECT
Test: OboeTester TEST INPUT
Test: open an MMAP stream and then plug in a headet
Test: it should close the input stream.
Change-Id: I51f0517e719b847f519bb08d3e5b0afb9b4d2f36

services/oboeservice/AAudioServiceEndpointMMAP.cpp

diff --git a/services/oboeservice/AAudioServiceEndpointMMAP.cpp b/services/oboeservice/AAudioServiceEndpointMMAP.cpp
index 133b9b4..290e9ff 100644
--- a/services/oboeservice/AAudioServiceEndpointMMAP.cpp
+++ b/services/oboeservice/AAudioServiceEndpointMMAP.cpp
@@ -90,6 +90,8 @@
 aaudio_result_t AAudioServiceEndpointMMAP::open(const aaudio::AAudioStreamRequest &request) {
     aaudio_result_t result = AAUDIO_OK;
     copyFrom(request.getConstantConfiguration());
+    mRequestedDeviceId = getDeviceId();
+
     mMmapClient.attributionSource = request.getAttributionSource();
     // TODO b/182392769: use attribution source util
     mMmapClient.attributionSource.uid = VALUE_OR_FATAL(
@@ -136,7 +138,7 @@
 
     const audio_attributes_t attributes = getAudioAttributesFrom(this);
 
-    mRequestedDeviceId = deviceId = getDeviceId();
+    deviceId = mRequestedDeviceId;
 
     // Fill in config
     config.format = audioFormat;
@@ -172,8 +174,10 @@
     audio_session_t sessionId = AAudioConvert_aaudioToAndroidSessionId(requestedSessionId);
 
     // Open HAL stream. Set mMmapStream
-    ALOGD("%s trying to open MMAP stream with format=%#x, sample_rate=%u, channel_mask=%#x",
-          __func__, config.format, config.sample_rate, config.channel_mask);
+    ALOGD("%s trying to open MMAP stream with format=%#x, "
+          "sample_rate=%u, channel_mask=%#x, device=%d",
+          __func__, config.format, config.sample_rate,
+          config.channel_mask, deviceId);
     status_t status = MmapStreamInterface::openMmapStream(streamDirection,
                                                           &attributes,
                                                           &config,
@@ -248,6 +252,9 @@
 
 error:
     close();
+    // restore original requests
+    setDeviceId(mRequestedDeviceId);
+    setSessionId(requestedSessionId);
     return result;
 }