commit 7b129548e46e6c0ba812ebf2a1a571b2c79d5f24
author Austin Borger <borgera@google.com> Thu Jun 09 13:23:06 2022 -0700
committer Austin Borger <borgera@google.com> Mon Jun 27 11:27:30 2022 -0700
tree 98c801ab96d09e7f6a2f4ff8eb5477a814dedf8e
parent 84b78a0192a32788b062ad4b6655053e9dca9633

CameraService: Check Thread::run for failed threads.

While a thread failing to launch is somewhat catastrophic, checking the
result and printing the error / returning early is good practice.

Test: Ran CameraThreadSafetyTest.
Change-Id: I8c1d3fe197ef8af631960dd286096287de9a280e

services/camera/libcameraservice/CameraServiceWatchdog.h

diff --git a/services/camera/libcameraservice/CameraServiceWatchdog.h b/services/camera/libcameraservice/CameraServiceWatchdog.h
index e55fa28..e35d69e 100644
--- a/services/camera/libcameraservice/CameraServiceWatchdog.h
+++ b/services/camera/libcameraservice/CameraServiceWatchdog.h
@@ -79,7 +79,13 @@
                     new CameraServiceWatchdog(cycles, cycleLength, mEnabled);
             mEnabledLock.unlock();
 
-            tempWatchdog->run("CameraServiceWatchdog");
+            status_t status = tempWatchdog->run("CameraServiceWatchdog");
+            if (status != OK) {
+                ALOGE("Unable to watch thread: %s (%d)", strerror(-status), status);
+                res = watchThread(func, tid);
+                return res;
+            }
+
             res = tempWatchdog->watchThread(func, tid);
             tempWatchdog->requestExit();
             tempWatchdog.clear();