commit 7840c30d04a749da9817682339f97b4ab128dffd
author Andy Hung <hunga@google.com> Sat Feb 24 01:33:26 2018 +0000
committer Eric Laurent <elaurent@google.com> Sat Feb 24 01:39:39 2018 +0000
tree f9dd3c1b47b99a5bb720fb51ca061625aa2a6306
parent cfb681346730d9d0cf849f44e234f79c1622f209

Revert "Ignore config error if non-offloadable effect is on offload thread"

This reverts commit cfb681346730d9d0cf849f44e234f79c1622f209.

Reason for revert: Crashes in Play Music b/73624638
Test: Play Music with cleared app data, check equalizer settings
Bug: 73624638
Bug: 70912361
Change-Id: I6d4eec2fda57a60c2c6949937752d8f1e50bb8ab

services/audioflinger/Effects.cpp

diff --git a/services/audioflinger/Effects.cpp b/services/audioflinger/Effects.cpp
index 0ce5350..979290f 100644
--- a/services/audioflinger/Effects.cpp
+++ b/services/audioflinger/Effects.cpp
@@ -589,13 +589,6 @@
         status = cmdStatus;
     }
 
-    // Ignore error if non-offloadable effect is created on an offload thread.
-    // Will be switched to non-offload thread when the effect is enabled.
-    if (status != NO_ERROR && thread->type() == ThreadBase::OFFLOAD && !isOffloaded()) {
-        ALOGV("Ignore error %d on non-offloadable effect on offload thread", status);
-        status = NO_ERROR;
-    }
-
 #ifdef MULTICHANNEL_EFFECT_CHAIN
     if (status != NO_ERROR &&
             (mConfig.inputCfg.channels != AUDIO_CHANNEL_OUT_STEREO