commit 70ff2371153fa253fa7b674de1d73f2666f76152
author Mikhail Naganov <mnaganov@google.com> Mon Dec 07 22:18:49 2020 +0000
committer Mikhail Naganov <mnaganov@google.com> Tue Dec 08 16:47:27 2020 +0000
tree 4373418248763a513521bfbec44c250eaa43c61d
parent 9b95dd2f7e88bd1ddaf5b765ffe7845cabe6edbc

Provide more info about AppOps checking

Add information about the package and the returned mode
to help investigating denials.

Bug: 174792335
Test: m
Change-Id: Ibf8cac99688ee268893bf00f2cff8675e6cbcf67

media/utils/ServiceUtilities.cpp

diff --git a/media/utils/ServiceUtilities.cpp b/media/utils/ServiceUtilities.cpp
index 87ea084..143a4e1 100644
--- a/media/utils/ServiceUtilities.cpp
+++ b/media/utils/ServiceUtilities.cpp
@@ -89,14 +89,18 @@
     AppOpsManager appOps;
     const int32_t op = appOps.permissionToOpCode(sAndroidPermissionRecordAudio);
     if (start) {
-        if (appOps.startOpNoThrow(op, uid, resolvedOpPackageName, /*startIfModeDefault*/ false)
-                != AppOpsManager::MODE_ALLOWED) {
-            ALOGE("Request denied by app op: %d", op);
+        if (int32_t mode = appOps.startOpNoThrow(
+                        op, uid, resolvedOpPackageName, /*startIfModeDefault*/ false);
+                mode != AppOpsManager::MODE_ALLOWED) {
+            ALOGE("Request start for \"%s\" (uid %d) denied by app op: %d, mode: %d",
+                    String8(resolvedOpPackageName).c_str(), uid, op, mode);
             return false;
         }
     } else {
-        if (appOps.checkOp(op, uid, resolvedOpPackageName) != AppOpsManager::MODE_ALLOWED) {
-            ALOGE("Request denied by app op: %d", op);
+        if (int32_t mode = appOps.checkOp(op, uid, resolvedOpPackageName);
+                mode != AppOpsManager::MODE_ALLOWED) {
+            ALOGE("Request check for \"%s\" (uid %d) denied by app op: %d, mode: %d",
+                    String8(resolvedOpPackageName).c_str(), uid, op, mode);
             return false;
         }
     }