| commit | 6e506fcd5e71c9b08683ea66038f6c33038b9e8e | [log] [tgz] |
|---|---|---|
| author | jiabin <jiabin@google.com> | Tue Jun 27 18:22:35 2023 +0000 |
| committer | jiabin <jiabin@google.com> | Fri Dec 08 22:06:21 2023 +0000 |
| tree | 28b92ad82cabb7721f9e12fc63453ce7bd6a57d4 | |
| parent | b72144c5ea90040655b34dabc2f2f317dfef9b74 [diff] [blame] |
Accessing tee patches with holding the thread lock. There is race that the tee patches can be updated from thread loop and the tee patches can also be accessed when the client has some operations. In that case, it will be safe to access tee patches with holding the thread lock. Bug: 286576245 Test: atest AudioPlaybackCaptureTest (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7434e81670e459054a94fd1bb51a963547440b0e) Merged-In: Ia704350ed5b3c914448ee609da33b867e3aa7626 Change-Id: Ia704350ed5b3c914448ee609da33b867e3aa7626
diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp index 180c150..98b6c27 100644 --- a/services/audioflinger/AudioFlinger.cpp +++ b/services/audioflinger/AudioFlinger.cpp
@@ -3823,7 +3823,7 @@ patchTrack->setPeerProxy(patchRecord, true /* holdReference */); patchRecord->setPeerProxy(patchTrack, false /* holdReference */); } - track->setTeePatchesToUpdate(std::move(teePatches)); + track->setTeePatchesToUpdate_l(std::move(teePatches)); } sp<audioflinger::SyncEvent> AudioFlinger::createSyncEvent(AudioSystem::sync_event_t type,