commit 6d4bf6eda04888144ec59cba4816a2cbb79b9e5c
author Glenn Kasten <gkasten@google.com> Fri Dec 16 07:30:14 2011 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Fri Dec 16 07:30:14 2011 -0800
tree 213424db0d71f1de94ea2789d272595287664bf6
parent b87c068727a15a3d3f0bfdcb758c76a097f5e869
parent fba380a0b2c62684ce4272a05165965bae29d6a1

Merge "setActiveTrack and setBufferProvider can't fail"

services/audioflinger/AudioMixer.cpp

diff --git a/services/audioflinger/AudioMixer.cpp b/services/audioflinger/AudioMixer.cpp
index f302b2f..1ebcd26 100644
--- a/services/audioflinger/AudioMixer.cpp
+++ b/services/audioflinger/AudioMixer.cpp
@@ -18,6 +18,7 @@
 #define LOG_TAG "AudioMixer"
 //#define LOG_NDEBUG 0
 
+#include <assert.h>
 #include <stdint.h>
 #include <string.h>
 #include <stdlib.h>
@@ -161,13 +162,12 @@
     }
 }
 
-status_t AudioMixer::setActiveTrack(int track)
+void AudioMixer::setActiveTrack(int track)
 {
-    if (uint32_t(track-TRACK0) >= MAX_NUM_TRACKS) {
-        return BAD_VALUE;
-    }
-    mActiveTrack = track - TRACK0;
-    return NO_ERROR;
+    // this also catches track < TRACK0
+    track -= TRACK0;
+    assert(uint32_t(track) < MAX_NUM_TRACKS);
+    mActiveTrack = track;
 }
 
 status_t AudioMixer::setParameter(int target, int name, void *value)
@@ -324,10 +324,9 @@
 }
 
 
-status_t AudioMixer::setBufferProvider(AudioBufferProvider* buffer)
+void AudioMixer::setBufferProvider(AudioBufferProvider* buffer)
 {
     mState.tracks[ mActiveTrack ].bufferProvider = buffer;
-    return NO_ERROR;
 }
 
 

services/audioflinger/AudioMixer.h

diff --git a/services/audioflinger/AudioMixer.h b/services/audioflinger/AudioMixer.h
index 02722d7..f380b35 100644
--- a/services/audioflinger/AudioMixer.h
+++ b/services/audioflinger/AudioMixer.h
@@ -80,10 +80,10 @@
     void        enable();
     void        disable();
 
-    status_t    setActiveTrack(int track);
+    void        setActiveTrack(int track);
     status_t    setParameter(int target, int name, void *value);
 
-    status_t    setBufferProvider(AudioBufferProvider* bufferProvider);
+    void        setBufferProvider(AudioBufferProvider* bufferProvider);
     void        process();
 
     uint32_t    trackNames() const { return mTrackNames; }