commit 6a30c8fa07d20e9346dac9359a9ddf5a98496a25
author Harish Mahendrakar <harish.mahendrakar@ittiam.com> Tue Mar 09 15:39:30 2021 -0800
committer Harish Mahendrakar <harish.mahendrakar@ittiam.com> Tue Mar 09 16:07:26 2021 -0800
tree d000057c9ef1777494601a3aab6721ba3fcc6f5b
parent 85ed8fd8d8aba408e2ee149a4a457772e82b479f

libeffects: Fix LVDBE biquad instance creation

LVDBE HPF biquad was created everytime LVDBE_Control was
called, but LVDBE_SetFilters was called only when there
was a change in parameters.

biquad creation is now done only when number of channels
changes and SetFilters is called for change in number of
channels as well.

Bug: 179462586
Test: lvm/tests/build_and_run_all_unit_tests.sh
Change-Id: I2edd4e02de28a36b3fb455cec6d6e63f16dbcc9f

media/libeffects/lvm/lib/Bass/src/LVDBE_Control.cpp

diff --git a/media/libeffects/lvm/lib/Bass/src/LVDBE_Control.cpp b/media/libeffects/lvm/lib/Bass/src/LVDBE_Control.cpp
index 3fc9e95..9fe8116 100644
--- a/media/libeffects/lvm/lib/Bass/src/LVDBE_Control.cpp
+++ b/media/libeffects/lvm/lib/Bass/src/LVDBE_Control.cpp
@@ -277,13 +277,15 @@
     /*
      * Create biquad instance
      */
-    pInstance->pHPFBiquad.reset(
-            new android::audio_utils::BiquadFilter<LVM_FLOAT>(pParams->NrChannels));
-
+    if (pInstance->Params.NrChannels != pParams->NrChannels) {
+        pInstance->pHPFBiquad.reset(
+                new android::audio_utils::BiquadFilter<LVM_FLOAT>(pParams->NrChannels));
+    }
     /*
      * Update the filters
      */
     if ((pInstance->Params.SampleRate != pParams->SampleRate) ||
+        (pInstance->Params.NrChannels != pParams->NrChannels) ||
         (pInstance->Params.CentreFrequency != pParams->CentreFrequency)) {
         LVDBE_SetFilters(pInstance, /* Instance pointer */
                          pParams);  /* New parameters */

media/libeffects/lvm/lib/Bass/src/LVDBE_Init.cpp

diff --git a/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.cpp b/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.cpp
index bbe7de0..b113f48 100644
--- a/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.cpp
+++ b/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.cpp
@@ -79,6 +79,7 @@
     pInstance->Params.SampleRate = LVDBE_FS_8000;
     pInstance->Params.VolumeControl = LVDBE_VOLUME_OFF;
     pInstance->Params.VolumedB = 0;
+    pInstance->Params.NrChannels = FCC_2;
 
     /*
      * Create pointer to data and coef memory
@@ -91,7 +92,7 @@
      * Create biquad instance
      */
     pInstance->pHPFBiquad.reset(
-            new android::audio_utils::BiquadFilter<LVM_FLOAT>(LVM_MAX_CHANNELS));
+            new android::audio_utils::BiquadFilter<LVM_FLOAT>(pInstance->Params.NrChannels));
     pInstance->pBPFBiquad.reset(new android::audio_utils::BiquadFilter<LVM_FLOAT>(FCC_1));
 
     /*