commit 694ebf6734cc7af6b8cf9c032fa3e5a00a54dc84
author Robert Shih <robertshih@google.com> Fri Mar 10 17:23:52 2017 -0800
committer Robert Shih <robertshih@google.com> Sat Mar 11 01:29:35 2017 +0000
tree 4b01707f9b9ca011d8da5fdaac3417a762b9d575
parent d095e65c8c125c555046c60539a0f7abf0ccf271

Fix Omx emptyBuffer fd leak in GraphicBufferSource

Bug: 36110748
Test: adb shell am instrument -e size small -w android.media.cts/android.support.test.runner.AndroidJUnitRunner
Change-Id: I733bb9a0206760e8cdd74a6a72ae40f8bffaaac8

media/libstagefright/omx/hal/1.0/impl/WGraphicBufferSource.cpp

diff --git a/media/libstagefright/omx/hal/1.0/impl/WGraphicBufferSource.cpp b/media/libstagefright/omx/hal/1.0/impl/WGraphicBufferSource.cpp
index 13e1f2f..3c2face 100644
--- a/media/libstagefright/omx/hal/1.0/impl/WGraphicBufferSource.cpp
+++ b/media/libstagefright/omx/hal/1.0/impl/WGraphicBufferSource.cpp
@@ -47,12 +47,16 @@
             const sp<GraphicBuffer> &buffer,
             int64_t timestamp, int fenceFd) override {
         CodecBuffer tBuffer;
-        return toStatusT(mOmxNode->emptyBuffer(
+        native_handle_t* fenceNh = native_handle_create_from_fd(fenceFd);
+        status_t err = toStatusT(mOmxNode->emptyBuffer(
               bufferId,
               *wrapAs(&tBuffer, buffer),
               flags,
               toRawTicks(timestamp),
-              native_handle_create_from_fd(fenceFd)));
+              fenceNh));
+        native_handle_close(fenceNh);
+        native_handle_delete(fenceNh);
+        return err;
     }
 
     virtual void dispatchDataSpaceChanged(