Avoid a couple string copies
We pass by const reference, instead of by value/copy, in a
couple places.
Test: TreeHugger
Bug: 200055138
Bug: 170964303
Change-Id: I8a0e642b06beab0b92676017cd6e1f50536a2d79
diff --git a/drm/libmediadrm/DrmMetricsConsumer.cpp b/drm/libmediadrm/DrmMetricsConsumer.cpp
index dca3050..c06f09b 100644
--- a/drm/libmediadrm/DrmMetricsConsumer.cpp
+++ b/drm/libmediadrm/DrmMetricsConsumer.cpp
@@ -32,7 +32,7 @@
namespace {
-std::string GetAttributeName(std::string typeName, uint32_t attribute) {
+std::string GetAttributeName(const std::string &typeName, uint32_t attribute) {
if (typeName == "KeyStatusChange") {
static const char *type_names[] = {"USABLE", "EXPIRED",
"OUTPUT_NOT_ALLOWED", "STATUS_PENDING",
@@ -85,7 +85,7 @@
template <typename T>
void ExportCounterMetricWithAttributeNames(
- const android::CounterMetric<T> &counter, std::string typeName, PersistableBundle *metrics) {
+ const android::CounterMetric<T> &counter, const std::string &typeName, PersistableBundle *metrics) {
if (!metrics) {
ALOGE("metrics was unexpectedly null.");
return;