commit 675bad658b603adc8cb5fc9f7b2707c24dedda9f
author François Gaffie <francois.gaffie@renault.com> Mon May 27 14:54:28 2024 +0200
committer Shunkai Yao <yaoshunkai@google.com> Fri Jul 12 05:32:32 2024 +0000
tree 8b5ea3736e0ce32740edf6db8f4e294bbd51dfa1
parent 9b5cbdbecd516bdc76d8362e9da12ad6b0f6ae77

Fix device effect creation for AIDL Audio Effect HAL

HIDL Effect Factory used to check the major (>=6) to allow Device effect.
AIDL Effect Factory has only taken into account the case major < 6,
thus preventing to create device effect.

Flag: EXEMPT bugfix
Bug: 329395147
Test: atest CtsMediaAudioTestCase

Change-Id: Id30431404fb810ca8ff9be3700b14591b8e04214
Signed-off-by: François Gaffie <francois.gaffie@renault.com>

media/libaudiohal/impl/EffectsFactoryHalAidl.cpp

diff --git a/media/libaudiohal/impl/EffectsFactoryHalAidl.cpp b/media/libaudiohal/impl/EffectsFactoryHalAidl.cpp
index 64cc7ed..740bf60 100644
--- a/media/libaudiohal/impl/EffectsFactoryHalAidl.cpp
+++ b/media/libaudiohal/impl/EffectsFactoryHalAidl.cpp
@@ -174,9 +174,6 @@
     if (uuid == nullptr || effect == nullptr) {
         return BAD_VALUE;
     }
-    if (sessionId == AUDIO_SESSION_DEVICE && ioId == AUDIO_IO_HANDLE_NONE) {
-        return INVALID_OPERATION;
-    }
     ALOGV("%s session %d ioId %d", __func__, sessionId, ioId);
 
     AudioUuid aidlUuid =