commit 61ccb486307410177ce565f960d989e42bb6d972
author Mikhail Naganov <mnaganov@google.com> Fri Sep 08 17:10:16 2023 -0700
committer Mikhail Naganov <mnaganov@google.com> Mon Sep 11 15:13:37 2023 -0700
tree 1e9e904550740facf4f6f242f00714a9cb3a3d0f
parent 02038015acaa3913bf41deb5e7487021ab8ab7c9

libaudiohal@aidl: Fix port config matching in findOrCreatePortConfig

The condition for determining that there is no existing port
config was not correct.

Also, clarify the output produced by audiosystem_tests to make
it easier to analyze.

Bug: 298175108
Test: atest audiosystem_tests
Change-Id: I1ae46d99fa1617f1ad4f508a78660bb63d66be8e

media/libaudiohal/impl/DeviceHalAidl.cpp

diff --git a/media/libaudiohal/impl/DeviceHalAidl.cpp b/media/libaudiohal/impl/DeviceHalAidl.cpp
index 2fa83a9..e0110cf 100644
--- a/media/libaudiohal/impl/DeviceHalAidl.cpp
+++ b/media/libaudiohal/impl/DeviceHalAidl.cpp
@@ -1516,7 +1516,7 @@
         }
         RETURN_STATUS_IF_ERROR(createOrUpdatePortConfig(requestedPortConfig, &portConfigIt,
                 created));
-    } else if (!flags.has_value()) {
+    } else if (portConfigIt == mPortConfigs.end() && !flags.has_value()) {
         ALOGW("%s: mix port config for %s, handle %d not found in the module %s, "
                 "and was not created as flags are not specified",
                 __func__, config.toString().c_str(), ioHandle, mInstance.c_str());