Revert "Add mInterfaceLock back to Camera3Device methods called by RequestThread."
This reverts commit 646c31b058e25dd8ee44ff4ec5a5c3005c8c829c.
Reason for revert: mInterfaceLock should not be held by methods which don't make a HAL interface call. It leads to a deadlock bw threadLoop and methods like createInputStream in scenarios where both try to trigger reconfiguration (for eg on updating session parameters).
Bug: 241137777
Test: Camera CTS
Change-Id: I818420a0a02caaf616dabc9f21ed8487a5674890
diff --git a/services/camera/libcameraservice/device3/Camera3Device.h b/services/camera/libcameraservice/device3/Camera3Device.h
index abfd9aa..977b57f 100644
--- a/services/camera/libcameraservice/device3/Camera3Device.h
+++ b/services/camera/libcameraservice/device3/Camera3Device.h
@@ -366,6 +366,7 @@
// A lock to enforce serialization on the input/configure side
// of the public interface.
+ // Only locked by public methods inherited from CameraDeviceBase.
// Not locked by methods guarded by mOutputLock, since they may act
// concurrently to the input/configure side of the interface.
// Must be locked before mLock if both will be locked by a method