commit 4fe34f9bd4e6836bfebcd4732c503795e5a0e2de
author Chong Zhang <chz@google.com> Tue Oct 06 15:47:28 2020 -0700
committer Chong Zhang <chz@google.com> Tue Oct 06 16:04:09 2020 -0700
tree 54f462eca4212127d98ad67af7e30751371799d4
parent 358a08446b6657151ad064edf44635e7d021c0af

transcoding: fix client number in unit tests

The unit test's client number check will fail with
MediaProvider registering a client. Relax client
number check after register and remove the check
after unregister.

bug: 154733526
test: MediaTranscodingService unit tests
Change-Id: I5dd6e88a8fa55480095ff83123065c71eb7e2e04

services/mediatranscoding/tests/MediaTranscodingServiceTestHelper.h

diff --git a/services/mediatranscoding/tests/MediaTranscodingServiceTestHelper.h b/services/mediatranscoding/tests/MediaTranscodingServiceTestHelper.h
index 0af572e..6d0b99e 100644
--- a/services/mediatranscoding/tests/MediaTranscodingServiceTestHelper.h
+++ b/services/mediatranscoding/tests/MediaTranscodingServiceTestHelper.h
@@ -439,6 +439,7 @@
             ALOGE("Failed to connect to the media.trascoding service.");
             return;
         }
+
         mClient1 = ::ndk::SharedRefBase::make<TestClientCallback>(kClientPackageA, 1);
         mClient2 = ::ndk::SharedRefBase::make<TestClientCallback>(kClientPackageB, 2);
         mClient3 = ::ndk::SharedRefBase::make<TestClientCallback>(kClientPackageC, 3);
@@ -469,7 +470,7 @@
         int32_t numOfClients;
         Status status = mService->getNumOfClients(&numOfClients);
         EXPECT_TRUE(status.isOk());
-        EXPECT_EQ(3, numOfClients);
+        EXPECT_GE(numOfClients, 3);
     }
 
     void unregisterMultipleClients() {
@@ -477,12 +478,6 @@
         EXPECT_TRUE(mClient1->unregisterClient().isOk());
         EXPECT_TRUE(mClient2->unregisterClient().isOk());
         EXPECT_TRUE(mClient3->unregisterClient().isOk());
-
-        // Check the number of clients.
-        int32_t numOfClients;
-        Status status = mService->getNumOfClients(&numOfClients);
-        EXPECT_TRUE(status.isOk());
-        EXPECT_EQ(0, numOfClients);
     }
 
     void deleteFile(const char* path) { unlink(path); }