commit 4fa100966e1056dcfafd7378f123da1feb21fbb1
author Shunkai Yao <yaoshunkai@google.com> Thu Apr 04 17:30:48 2024 +0000
committer Shunkai Yao <yaoshunkai@google.com> Mon Apr 08 22:27:43 2024 +0000
tree c8134c475d7fed380ca815123b2feb1f4d5b8420
parent e852899874d9628614135f8b12f871ace0526418

Assert effect hal interface not null before access

Also add debugging information to assert

Bug: 315995877
Test: atest CtsMediaAudioTestCases
Change-Id: Ic43c375bb57b64bb169eece8f7be28f011ecebc0

services/audioflinger/Effects.h

diff --git a/services/audioflinger/Effects.h b/services/audioflinger/Effects.h
index 0fa1b83..64a4e62 100644
--- a/services/audioflinger/Effects.h
+++ b/services/audioflinger/Effects.h
@@ -228,7 +228,7 @@
     bool isOffloaded_l() const final
             REQUIRES(audio_utils::EffectChain_Mutex) EXCLUDES_EffectBase_Mutex;
     void addEffectToHal_l() final REQUIRES(audio_utils::EffectChain_Mutex);
-    void release_l() final REQUIRES(audio_utils::EffectChain_Mutex);
+    void release_l(const std::string& from = "") final REQUIRES(audio_utils::EffectChain_Mutex);
 
     sp<IAfEffectModule> asEffectModule() final { return this; }
 
@@ -308,6 +308,8 @@
     pid_t mSetVolumeReentrantTid = INVALID_PID;
 
     std::optional<std::vector<uint32_t>> mVolume;
+    // TODO: b/315995877, remove this debugging string after root cause
+    std::string mEffectInterfaceDebug;
 };
 
 // The EffectHandle class implements the IEffect interface. It provides resources