commit 49879b768e559201b86e78190df1fdd57687fb30
author Eric Laurent <elaurent@google.com> Tue Dec 20 20:20:23 2022 +0100
committer Shunkai Yao <yaoshunkai@google.com> Wed Jan 04 19:53:28 2023 +0000
tree aa5a8876d4f7f18509e14c77ac4bd739e77dacc9
parent 01eb164076a1bd90e1f22a91eb6643eec1c6455d

audio flinger: rename Bluetooth latency mode APIs

Rename APIs controlling Bluetooth variable latency
after API review suggestions.

Bug: 257922898
Test: make

Merged-In: I517ad9c6aef14975c9e0a1a2703d1b17d638ea0e
Change-Id: I517ad9c6aef14975c9e0a1a2703d1b17d638ea0e

services/audioflinger/AudioFlinger.cpp

diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp
index 7e1ca5f..4a8b678 100644
--- a/services/audioflinger/AudioFlinger.cpp
+++ b/services/audioflinger/AudioFlinger.cpp
@@ -231,8 +231,9 @@
 BINDER_METHOD_ENTRY(setDeviceConnectedState) \
 BINDER_METHOD_ENTRY(setRequestedLatencyMode) \
 BINDER_METHOD_ENTRY(getSupportedLatencyModes) \
-BINDER_METHOD_ENTRY(setBluetoothLatencyModesEnabled) \
-BINDER_METHOD_ENTRY(supportsBluetoothLatencyModes) \
+BINDER_METHOD_ENTRY(setBluetoothVariableLatencyEnabled) \
+BINDER_METHOD_ENTRY(isBluetoothVariableLatencyEnabled) \
+BINDER_METHOD_ENTRY(supportsBluetoothVariableLatency) \
 
 // singleton for Binder Method Statistics for IAudioFlinger
 static auto& getIAudioFlingerStatistics() {
@@ -1617,12 +1618,12 @@
     return thread->getSupportedLatencyModes(modes);
 }
 
-status_t AudioFlinger::setBluetoothLatencyModesEnabled(bool enabled) {
+status_t AudioFlinger::setBluetoothVariableLatencyEnabled(bool enabled) {
     Mutex::Autolock _l(mLock);
     status_t status = INVALID_OPERATION;
     for (size_t i = 0; i < mPlaybackThreads.size(); i++) {
         // Success if at least one PlaybackThread supports Bluetooth latency modes
-        if (mPlaybackThreads.valueAt(i)->setBluetoothLatencyModesEnabled(enabled) == NO_ERROR) {
+        if (mPlaybackThreads.valueAt(i)->setBluetoothVariableLatencyEnabled(enabled) == NO_ERROR) {
             status = NO_ERROR;
         }
     }
@@ -1632,14 +1633,22 @@
     return status;
 }
 
-status_t AudioFlinger::supportsBluetoothLatencyModes(bool* support) {
+status_t AudioFlinger::isBluetoothVariableLatencyEnabled(bool *enabled) {
+    if (enabled == nullptr) {
+        return BAD_VALUE;
+    }
+    *enabled = mBluetoothLatencyModesEnabled.load();
+    return NO_ERROR;
+}
+
+status_t AudioFlinger::supportsBluetoothVariableLatency(bool* support) {
     if (support == nullptr) {
         return BAD_VALUE;
     }
     Mutex::Autolock _l(mLock);
     *support = false;
     for (size_t i = 0; i < mAudioHwDevs.size(); i++) {
-        if (mAudioHwDevs.valueAt(i)->supportsBluetoothLatencyModes()) {
+        if (mAudioHwDevs.valueAt(i)->supportsBluetoothVariableLatency()) {
              *support = true;
              break;
         }
@@ -2549,7 +2558,7 @@
 
 
     if (bool supports = false;
-            dev->supportsBluetoothLatencyModes(&supports) == NO_ERROR && supports) {
+            dev->supportsBluetoothVariableLatency(&supports) == NO_ERROR && supports) {
         flags = static_cast<AudioHwDevice::Flags>(flags |
                 AudioHwDevice::AHWD_SUPPORTS_BT_LATENCY_MODES);
     }
@@ -2904,7 +2913,7 @@
             if (thread->isMsdDevice()) {
                 thread->setDownStreamPatch(&patch);
             }
-            thread->setBluetoothLatencyModesEnabled(mBluetoothLatencyModesEnabled.load());
+            thread->setBluetoothVariableLatencyEnabled(mBluetoothLatencyModesEnabled.load());
             return thread;
         }
     }
@@ -4601,8 +4610,9 @@
         case TransactionCode::SET_AUDIO_HAL_PIDS:
         case TransactionCode::SET_VIBRATOR_INFOS:
         case TransactionCode::UPDATE_SECONDARY_OUTPUTS:
-        case TransactionCode::SET_BLUETOOTH_LATENCY_MODES_ENABLED:
-        case TransactionCode::SUPPORTS_BLUETOOTH_LATENCY_MODES: {
+        case TransactionCode::SET_BLUETOOTH_VARIABLE_LATENCY_ENABLED:
+        case TransactionCode::IS_BLUETOOTH_VARIABLE_LATENCY_ENABLED:
+        case TransactionCode::SUPPORTS_BLUETOOTH_VARIABLE_LATENCY: {
             if (!isServiceUid(IPCThreadState::self()->getCallingUid())) {
                 ALOGW("%s: transaction %d received from PID %d unauthorized UID %d",
                       __func__, code, IPCThreadState::self()->getCallingPid(),