commit 47dcb48b5a355bdfe43b9e1dfb7487c7a08abb3d
author Sungtak Lee <taklee@google.com> Fri Apr 15 10:47:08 2022 -0700
committer Sungtak Lee <taklee@google.com> Fri Apr 15 12:59:38 2022 -0700
tree ac2b3bf882b847608659b1eac9c5d426691acf79
parent 12c71eef7753eaf5300b709632368767f57c38b3

CCodec: Do not crash when there is no OMX service

Before dereferncing OMX service, check whether the service is retrieved
and valid.

Bug: 205761766
Change-Id: Iff3aed110949469a27e0ffdb530eb9344a5d97ad

media/codec2/sfplugin/CCodec.cpp

diff --git a/media/codec2/sfplugin/CCodec.cpp b/media/codec2/sfplugin/CCodec.cpp
index 3302dd3..cb362c9 100644
--- a/media/codec2/sfplugin/CCodec.cpp
+++ b/media/codec2/sfplugin/CCodec.cpp
@@ -1526,6 +1526,9 @@
     using namespace android::hardware::graphics::bufferqueue::V1_0::utils;
     typedef android::hardware::media::omx::V1_0::Status OmxStatus;
     android::sp<IOmx> omx = IOmx::getService();
+    if (omx == nullptr) {
+        return nullptr;
+    }
     typedef android::hardware::graphics::bufferqueue::V1_0::
             IGraphicBufferProducer HGraphicBufferProducer;
     typedef android::hardware::media::omx::V1_0::