commit 46f1c24c5ac7711702147c4db20e791827a88371
author Eric Laurent <elaurent@google.com> Thu Aug 18 12:35:37 2016 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Aug 18 12:35:37 2016 +0000
tree 032afd3f2cb059fa6b5445e8a442bffc86921b3c
parent b480ab936556056851ea5cecaed1528b6b035884
parent f97b682f0e4a08bb6211f230a789a80981a7111c

Merge "Fix for tone glitch produced in ToneGenerator"

include/media/ToneGenerator.h

diff --git a/include/media/ToneGenerator.h b/include/media/ToneGenerator.h
index 8406ed6..92ccd28 100644
--- a/include/media/ToneGenerator.h
+++ b/include/media/ToneGenerator.h
@@ -304,7 +304,7 @@
 
         short mA1_Q14;  // Q14 coefficient
         // delay line of full amplitude generator
-        short mS1, mS2;  // delay line S2 oldest
+        long mS1, mS2;  // delay line S2 oldest
         short mS2_0;  // saved value for reinitialisation
         short mAmplitude_Q15;  // Q15 amplitude
     };

media/libmedia/ToneGenerator.cpp

diff --git a/media/libmedia/ToneGenerator.cpp b/media/libmedia/ToneGenerator.cpp
index 68f2403..e01947f 100644
--- a/media/libmedia/ToneGenerator.cpp
+++ b/media/libmedia/ToneGenerator.cpp
@@ -1570,8 +1570,8 @@
         lS1 = (long)0;
         lS2 = (long)mS2_0;
     } else {
-        lS1 = (long)mS1;
-        lS2 = (long)mS2;
+        lS1 = mS1;
+        lS2 = mS2;
     }
     lA1 = (long)mA1_Q14;
     lAmplitude = (long)mAmplitude_Q15;
@@ -1607,8 +1607,8 @@
     }
 
     // save status
-    mS1 = (short)lS1;
-    mS2 = (short)lS2;
+    mS1 = lS1;
+    mS2 = lS2;
 }
 
 }  // end namespace android