commit 44824a244f514ff8d80317141e418ef689b1344c
author Jaideep Sharma <quic_jaidshar@quicinc.com> Tue Jun 18 16:32:34 2024 +0530
committer Mikhail Naganov <mnaganov@google.com> Mon Jul 08 17:01:45 2024 -0700
tree b7430cc4141108266bf0165ddaa0eff3dc0f1b74
parent 69e093ecf3d4ce77224a5c8ac92b4026653515f4

audiopolicy: skip opening mmap profile during new device connection

During the new device connection, all listed mix ports ported are
opened, but for mmap case, when output or input is opened, it neads to
call createMmapBuffer which goes till audio DSP, adding up to latency
during device connections.

Skip opening input/output for mmap profiles during device connections.
Once, device is connected, if client needs a mmap session, mmap
sessions can be opened on the go.

Flag: EXEMPT bugfix
Bug: 345692843
Test: connect an external device, check opened inputs / outputs,
      verify logs, after device connection play mmap
Test: run audiopolicy_tests
Change-Id: Iefcc3db8f30348347e1b107a6281cf8b6268d493
Merged-In: Iefcc3db8f30348347e1b107a6281cf8b6268d493

services/audiopolicy/managerdefault/AudioPolicyManager.cpp

diff --git a/services/audiopolicy/managerdefault/AudioPolicyManager.cpp b/services/audiopolicy/managerdefault/AudioPolicyManager.cpp
index 679f0ee..cc44299 100644
--- a/services/audiopolicy/managerdefault/AudioPolicyManager.cpp
+++ b/services/audiopolicy/managerdefault/AudioPolicyManager.cpp
@@ -6386,6 +6386,14 @@
             if (!mConfig->getOutputDevices().contains(supportedDevice)) {
                 continue;
             }
+
+            if (outProfile->isMmap() && !outProfile->hasDynamicAudioProfile()
+                && availProfileDevices.areAllDevicesAttached()) {
+                ALOGV("%s skip opening output for mmap profile %s", __func__,
+                        outProfile->getTagName().c_str());
+                continue;
+            }
+
             sp<SwAudioOutputDescriptor> outputDesc = new SwAudioOutputDescriptor(outProfile,
                                                                                  mpClientInterface);
             audio_io_handle_t output = AUDIO_IO_HANDLE_NONE;
@@ -6445,6 +6453,14 @@
                     __func__, inProfile->getTagName().c_str());
                 continue;
             }
+
+            if (inProfile->isMmap() && !inProfile->hasDynamicAudioProfile()
+                && availProfileDevices.areAllDevicesAttached()) {
+                ALOGV("%s skip opening input for mmap profile %s", __func__,
+                        inProfile->getTagName().c_str());
+                continue;
+            }
+
             sp<AudioInputDescriptor> inputDesc =
                     new AudioInputDescriptor(inProfile, mpClientInterface);
 
@@ -6599,7 +6615,11 @@
             if (j != outputs.size()) {
                 continue;
             }
-
+            if (profile->isMmap() && !profile->hasDynamicAudioProfile()) {
+                ALOGV("%s skip opening output for mmap profile %s",
+                      __func__, profile->getTagName().c_str());
+                continue;
+            }
             if (!profile->canOpenNewIo()) {
                 ALOGW("Max Output number %u already opened for this profile %s",
                       profile->maxOpenCount, profile->getTagName().c_str());
@@ -6750,6 +6770,11 @@
                 continue;
             }
 
+            if (profile->isMmap() && !profile->hasDynamicAudioProfile()) {
+                ALOGV("%s skip opening input for mmap profile %s",
+                      __func__, profile->getTagName().c_str());
+                continue;
+            }
             if (!profile->canOpenNewIo()) {
                 ALOGW("Max Input number %u already opened for this profile %s",
                       profile->maxOpenCount, profile->getTagName().c_str());