commit | 441b487ea1223cb7817b28ae5cff81ab5411193a | [log] [tgz] |
---|---|---|
author | Eric Laurent <elaurent@google.com> | Mon Jul 04 15:11:29 2022 +0200 |
committer | Andy Hung <hunga@google.com> | Tue Sep 06 18:46:36 2022 -0700 |
tree | 8130659252aa436df697dda0adfd121d2632e59c | |
parent | b22c6b259653c5ab9c13642acb47e029fbe70699 [diff] [blame] |
audio policy service: fix spatializer locking scheme The audio policy service should never call Spatializer controller methods with its mutex held. This rule was only partly repected. This CL fixes the remaining call sites. Bug: 237833275 Test: repro steps in the bug. Merged-In: I2a1828d9e4cd3e16a68c727ae84329c92666c6ab Change-Id: I2a1828d9e4cd3e16a68c727ae84329c92666c6ab
diff --git a/services/audiopolicy/service/AudioPolicyService.h b/services/audiopolicy/service/AudioPolicyService.h index 39218dd..5c37f99 100644 --- a/services/audiopolicy/service/AudioPolicyService.h +++ b/services/audiopolicy/service/AudioPolicyService.h
@@ -1060,6 +1060,7 @@ CaptureStateNotifier mCaptureStateNotifier; + // created in onFirstRef() and never cleared: does not need to be guarded by mLock sp<Spatializer> mSpatializer; void *mLibraryHandle = nullptr;