aaudio: clean up MMAP volume TODO
onVolumeChanged() passes in a list of channels and an associated
volume for each one.
However, both the sender (AudioFlinger) and the consumer (AAudio)
is not using this efficiently. AudioFlinger simply sets all the
volumes as the same value and AAudio simply uses the first value.
This CL removes the TODO and cleans up the function parameters.
Bug: 220162278
Test: OboeTester
Change-Id: I3d8b1ad7228e02e2db6d776af7f5a618fdf50a53
diff --git a/services/oboeservice/AAudioServiceEndpointMMAP.cpp b/services/oboeservice/AAudioServiceEndpointMMAP.cpp
index a266d5b..bf2342a 100644
--- a/services/oboeservice/AAudioServiceEndpointMMAP.cpp
+++ b/services/oboeservice/AAudioServiceEndpointMMAP.cpp
@@ -358,12 +358,8 @@
asyncTask.detach();
}
-void AAudioServiceEndpointMMAP::onVolumeChanged(audio_channel_mask_t channels,
- android::Vector<float> values) {
- // TODO Do we really need a different volume for each channel?
- // We get called with an array filled with a single value!
- float volume = values[0];
- ALOGD("%s() volume[0] = %f", __func__, volume);
+void AAudioServiceEndpointMMAP::onVolumeChanged(float volume) {
+ ALOGD("%s() volume = %f", __func__, volume);
std::lock_guard<std::mutex> lock(mLockStreams);
for(const auto& stream : mRegisteredStreams) {
stream->onVolumeChanged(volume);