commit 3ac211f58d4acb1c9865cbcf95677945a7b673d4
author Yi Kong <yikong@google.com> Mon Aug 12 07:31:44 2024 +0800
committer Yi Kong <yikong@google.com> Mon Aug 12 07:31:59 2024 +0800
tree 09179362f33d275c0db06b27b3c07c1f5516851b
parent 6fe6b4380a07766813edc4863721f3af8d5218b4

Remove unnecessary std::move

Moving a temporary object prevents copy elision, and could reduce
performance.

This fixes -Wpessimizing-move compiler warning.

Test: presubmit
Bug: 154270751
Change-Id: Ia0b02d90c239572c953007272f75900ee77c6305

services/mediaresourcemanager/ResourceManagerMetrics.cpp

diff --git a/services/mediaresourcemanager/ResourceManagerMetrics.cpp b/services/mediaresourcemanager/ResourceManagerMetrics.cpp
index a8a1de1..8b3711c 100644
--- a/services/mediaresourcemanager/ResourceManagerMetrics.cpp
+++ b/services/mediaresourcemanager/ResourceManagerMetrics.cpp
@@ -821,7 +821,7 @@
     metricsLog += getAppsPixelCount(mProcessPixelsMap);
     metricsLog += getAppsCodecUsageMetrics(mProcessConcurrentCodecsMap);
 
-    return std::move(metricsLog);
+    return metricsLog;
 }
 
 } // namespace android

services/mediaresourcemanager/ResourceManagerServiceUtils.cpp

diff --git a/services/mediaresourcemanager/ResourceManagerServiceUtils.cpp b/services/mediaresourcemanager/ResourceManagerServiceUtils.cpp
index 679ab13..49f68e9 100644
--- a/services/mediaresourcemanager/ResourceManagerServiceUtils.cpp
+++ b/services/mediaresourcemanager/ResourceManagerServiceUtils.cpp
@@ -94,7 +94,7 @@
         str.append("\n");
     }
 
-    return std::move(str);
+    return str;
 }
 
 bool ResourceList::operator==(const ResourceList& rhs) const {