commit 361155ac670d6e528309525e7737e9e2da4046ff
author Andy Hung <hunga@google.com> Mon Apr 09 15:27:02 2018 -0700
committer Andy Hung <hunga@google.com> Mon Apr 09 15:58:09 2018 -0700
tree b721950be3a9c5cd39bad710461b6a1f6964b94d
parent fa33327eb3b81bf1f2173bef0d13ced98b1221c1

EffectReverb: Fix unsigned integer overflow

Test: Regression - verified problem exists, can't trigger problem at will.
Bug: 77818338
Change-Id: I3dccf05c27e5048eddc39d58f22b02fba0bb9de1

media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp

diff --git a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
index 0630285..e1c03f9 100644
--- a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
+++ b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
@@ -1966,7 +1966,8 @@
 
     if (pContext->bEnabled == LVM_FALSE) {
         if (pContext->SamplesToExitCount > 0) {
-            pContext->SamplesToExitCount -= outBuffer->frameCount;
+            // signed - unsigned will trigger integer overflow if result becomes negative.
+            pContext->SamplesToExitCount -= (ssize_t)outBuffer->frameCount;
         } else {
             status = -ENODATA;
         }