commit 2a05df2563f083c875425a5846aa158c0d7f2ab6
author Ram Mohan M <ram.mohan@ittiam.com> Sun Aug 28 11:46:23 2022 +0530
committer Ram Mohan <ram.mohan@ittiam.com> Mon Aug 29 16:30:56 2022 +0530
tree b6e66edab05f22f7ae779c5ef77ea328f0bd6f49
parent 2d70375a46b64cba8a0a6d2be20718b4267f2235

AudioFlinger: propagate createEffect return status safely to caller

For device effects, in few scenarios, the createEffect status is getting
dropped mid way. This is addressed.

Bug: 244012057
Test: gts-tradefed run commandAndExit gts -m GtsAudioTestCases

Change-Id: Ie7db19f5c91ba73f026731025968cd22803580c9

services/audioflinger/DeviceEffectManager.cpp

diff --git a/services/audioflinger/DeviceEffectManager.cpp b/services/audioflinger/DeviceEffectManager.cpp
index 53ac5cb..4f3ed0a 100644
--- a/services/audioflinger/DeviceEffectManager.cpp
+++ b/services/audioflinger/DeviceEffectManager.cpp
@@ -106,8 +106,13 @@
         if (lStatus == NO_ERROR) {
             lStatus = effect->addHandle(handle.get());
             if (lStatus == NO_ERROR) {
-                effect->init(patches);
-                mDeviceEffects.emplace(device, effect);
+                lStatus = effect->init(patches);
+                if (lStatus == NAME_NOT_FOUND) {
+                    lStatus = NO_ERROR;
+                }
+                if (lStatus == NO_ERROR || lStatus == ALREADY_EXISTS) {
+                    mDeviceEffects.emplace(device, effect);
+                }
             }
         }
     }