commit 29f327a7849ac3cb48ce14c4840f69b5828027ff
author Shunkai Yao <yaoshunkai@google.com> Mon Aug 14 20:48:37 2023 +0000
committer Shunkai Yao <yaoshunkai@google.com> Wed Aug 16 16:03:31 2023 +0000
tree a4d5444a478372db4b48d83a345e2a96beba0071
parent 141d6b83f93ea30db107f6c8268fe341a9bc2f76

Send effect device/mode/source update if indicator was set in descriptor

Bug: 271500140
Test: Enable AIDL and test with YTM
Test: atest EffectsFactoryHalInterfaceTest
Change-Id: Ie85c2101eb37f2835d6e9e91a0ecc9273a250a0e

media/libaudiohal/impl/EffectHalAidl.cpp

diff --git a/media/libaudiohal/impl/EffectHalAidl.cpp b/media/libaudiohal/impl/EffectHalAidl.cpp
index b8e62ae..642d352 100644
--- a/media/libaudiohal/impl/EffectHalAidl.cpp
+++ b/media/libaudiohal/impl/EffectHalAidl.cpp
@@ -69,7 +69,6 @@
       mEffect(effect),
       mSessionId(sessionId),
       mIoId(ioId),
-      mDesc(desc),
       mIsProxyEffect(isProxyEffect) {
     createAidlConversion(effect, sessionId, ioId, desc);
 }
@@ -169,7 +168,8 @@
     State state = State::INIT;
     if (mConversion->isBypassing() || !mEffect->getState(&state).isOk() ||
         state != State::PROCESSING) {
-        ALOGI("%s skipping %s process because it's %s", __func__, mDesc.common.name.c_str(),
+        ALOGI("%s skipping %s process because it's %s", __func__,
+              mConversion->getDescriptor().common.name.c_str(),
               mConversion->isBypassing()
                       ? "bypassing"
                       : aidl::android::hardware::audio::effect::toString(state).c_str());
@@ -225,8 +225,8 @@
         return INVALID_OPERATION;
     }
 
-    ALOGD("%s %s consumed %zu produced %zu", __func__, mDesc.common.name.c_str(), floatsToWrite,
-          floatsToRead);
+    ALOGD("%s %s consumed %zu produced %zu", __func__,
+          mConversion->getDescriptor().common.name.c_str(), floatsToWrite, floatsToRead);
     return OK;
 }