commit 298764fdab19e0965fcafa2931fc307ad0119711
author My Name <wonsik@google.com> Fri Mar 25 15:07:51 2022 -0700
committer My Name <wonsik@google.com> Wed Mar 30 11:21:49 2022 -0700
tree a3e8f37a22a0a87718a9fb24da3c0e9ce97e42dd
parent 657dd4cc6cbdf9cbf9547b30aa2cc32d2150ff5c

Codec2InfoBuilder: list FormatSurface for c2.android.* decoders

Fixes: 221338308
Fixes: 226423619
Test: atest android.mediav2.cts.CodecInfoTest#testColorFormatSupport
Change-Id: Id9429d3f6ad34502bfa8e9ae698f1cd184c70203

media/codec2/sfplugin/Codec2InfoBuilder.cpp

diff --git a/media/codec2/sfplugin/Codec2InfoBuilder.cpp b/media/codec2/sfplugin/Codec2InfoBuilder.cpp
index 63bd64b..2b8a160 100644
--- a/media/codec2/sfplugin/Codec2InfoBuilder.cpp
+++ b/media/codec2/sfplugin/Codec2InfoBuilder.cpp
@@ -281,6 +281,11 @@
             }
         };
 
+        // The color format is ordered by preference. The intention here is to advertise:
+        //   c2.android.* codecs: YUV420s, Surface, <the rest>
+        //   all other codecs:    Surface, YUV420s, <the rest>
+        // TODO: get this preference via Codec2 API
+
         // vendor video codecs prefer opaque format
         if (trait.name.find("android") == std::string::npos) {
             addDefaultColorFormat(COLOR_FormatSurface);
@@ -290,9 +295,8 @@
         addDefaultColorFormat(COLOR_FormatYUV420SemiPlanar);
         addDefaultColorFormat(COLOR_FormatYUV420PackedPlanar);
         addDefaultColorFormat(COLOR_FormatYUV420PackedSemiPlanar);
-        // framework video encoders must support surface format, though it is unclear
-        // that they will be able to map it if it is opaque
-        if (encoder && trait.name.find("android") != std::string::npos) {
+        // Android video codecs prefer CPU-readable formats
+        if (trait.name.find("android") != std::string::npos) {
             addDefaultColorFormat(COLOR_FormatSurface);
         }
         for (int32_t colorFormat : supportedColorFormats) {