cameraserver: remove assumption that status change callbacks must be called from cameraserver process.
Some code in onDeviceStatusChanged, which is probably a remnant from
pre-treble days assumes
onDeviceStatusChanged callbacks can be made from only the cameraserver
process.
Post treble, this is not true since the cameraserver could receive a
cameraDeviceStatusChanged
callback from the camera HAL process (which could call
onDeviceStatusChanged).
Bug: 158252149
Test: Camera Application (validity)
Merged-In: Ic76ecf45b0c06dcb69d1b0758b7cd9047a0364ac
Change-Id: I76587e972940f78b6a84755d343d4cb60f4b474d
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
Change-Id: I29cea1efb44a73058eadaf653bf65addbbba6c4c
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
diff --git a/services/camera/libcameraservice/CameraService.cpp b/services/camera/libcameraservice/CameraService.cpp
index 595c3e8..70f4769 100644
--- a/services/camera/libcameraservice/CameraService.cpp
+++ b/services/camera/libcameraservice/CameraService.cpp
@@ -377,9 +377,6 @@
clientToDisconnect->notifyError(
hardware::camera2::ICameraDeviceCallbacks::ERROR_CAMERA_DISCONNECTED,
CaptureResultExtras{});
- // Ensure not in binder RPC so client disconnect PID checks work correctly
- LOG_ALWAYS_FATAL_IF(CameraThreadState::getCallingPid() != getpid(),
- "onDeviceStatusChanged must be called from the camera service process!");
clientToDisconnect->disconnect();
}