commit 28452eda70061041543aaf2e501982c467aa103e
author Marco Nelissen <marcone@google.com> Thu Oct 03 18:25:15 2019 -0700
committer android-build-merger <android-build-merger@google.com> Thu Oct 03 18:25:15 2019 -0700
tree 350d7508308bc1311fd7bab30b2cca3dbd57c5f6
parent c0c54e1324b151c9df97b247023c1d5996cda2d8
parent fada886dea606f423f7f958b4716a74f26853323

Merge "Fix memory leak in MPEG2PSExtractor" am: 52a42dde36 am: 8f56bd1ef1
am: fada886dea

Change-Id: Ie2b16301a4e7fa9d6b5d1f598ad123df42dfe989

media/extractors/mpeg2/MPEG2PSExtractor.cpp

diff --git a/media/extractors/mpeg2/MPEG2PSExtractor.cpp b/media/extractors/mpeg2/MPEG2PSExtractor.cpp
index 731584d..92ba039 100644
--- a/media/extractors/mpeg2/MPEG2PSExtractor.cpp
+++ b/media/extractors/mpeg2/MPEG2PSExtractor.cpp
@@ -111,8 +111,10 @@
     AMediaFormat *meta = AMediaFormat_new();
     for (size_t i = mTracks.size(); i > 0;) {
         i--;
-        if (mTracks.valueAt(i)->getFormat(meta) != AMEDIA_OK) {
+        Track *track = mTracks.valueAt(i);
+        if (track->getFormat(meta) != AMEDIA_OK) {
             mTracks.removeItemsAt(i);
+            delete track;
         }
     }
     AMediaFormat_delete(meta);
@@ -122,6 +124,10 @@
 
 MPEG2PSExtractor::~MPEG2PSExtractor() {
     delete mDataSource;
+    for (size_t i = mTracks.size(); i > 0;) {
+        i--;
+        delete mTracks.valueAt(i);
+    }
 }
 
 size_t MPEG2PSExtractor::countTracks() {
@@ -793,7 +799,9 @@
 }
 
 media_status_t MPEG2PSExtractor::WrappedTrack::start() {
+    delete mTrack->mBufferGroup;
     mTrack->mBufferGroup = mBufferGroup;
+    mBufferGroup = nullptr;
     return mTrack->start();
 }