commit 1c388a30c1ca41ecf523eaa1ab5613b4bb11abc9
author Andrew Chant <achant@google.com> Fri Jun 21 03:46:14 2019 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Fri Jun 21 03:46:14 2019 +0000
tree b1eb1fa37148ee2c39b3ca2f83bad48f4725f9b3
parent 69b360177ac78977e6ff88cd352601c09db36414
parent b233eaef6a0b9a0b38845de252322c5e7418cdcf

Merge "libcamera2ndk_vendor: stop looper thread on ~ACameraDevice()" into qt-r1-dev

camera/ndk/ndk_vendor/impl/ACameraDevice.cpp

diff --git a/camera/ndk/ndk_vendor/impl/ACameraDevice.cpp b/camera/ndk/ndk_vendor/impl/ACameraDevice.cpp
index a43d707..8a3bb46 100644
--- a/camera/ndk/ndk_vendor/impl/ACameraDevice.cpp
+++ b/camera/ndk/ndk_vendor/impl/ACameraDevice.cpp
@@ -44,6 +44,16 @@
 
 using namespace android;
 
+ACameraDevice::~ACameraDevice() {
+    Mutex::Autolock _l(mDevice->mDeviceLock);
+    if (mDevice->mCbLooper != nullptr) {
+      mDevice->mCbLooper->unregisterHandler(mDevice->mHandler->id());
+      mDevice->mCbLooper->stop();
+    }
+    mDevice->mCbLooper.clear();
+    mDevice->mHandler.clear();
+}
+
 namespace android {
 namespace acam {
 

camera/ndk/ndk_vendor/impl/ACameraDevice.h

diff --git a/camera/ndk/ndk_vendor/impl/ACameraDevice.h b/camera/ndk/ndk_vendor/impl/ACameraDevice.h
index 829b084..d8df568 100644
--- a/camera/ndk/ndk_vendor/impl/ACameraDevice.h
+++ b/camera/ndk/ndk_vendor/impl/ACameraDevice.h
@@ -135,6 +135,7 @@
 
   private:
     friend ACameraCaptureSession;
+    friend ACameraDevice;
 
     camera_status_t checkCameraClosedOrErrorLocked() const;
 
@@ -383,8 +384,7 @@
                   sp<ACameraMetadata> chars) :
             mDevice(new android::acam::CameraDevice(id, cb, std::move(chars), this)) {}
 
-    ~ACameraDevice() {};
-
+    ~ACameraDevice();
     /*******************
      * NDK public APIs *
      *******************/