Camera: cleanup some dead code
We no longer have code path running non-HIDL interface.
This cleanup also simplifies some logic needed for fixing
b/132594861
Bug: 132594861
Test: Camera CTS
Change-Id: If15ea359a1a59c5a8e7a59818ce4db8120000bc4
diff --git a/services/camera/libcameraservice/device3/Camera3Device.h b/services/camera/libcameraservice/device3/Camera3Device.h
index 8f74611..fe94f8e 100644
--- a/services/camera/libcameraservice/device3/Camera3Device.h
+++ b/services/camera/libcameraservice/device3/Camera3Device.h
@@ -289,9 +289,6 @@
// Reset this HalInterface object (does not call close())
void clear();
- // Check if HalInterface support sending requests in batch
- bool supportBatchRequest();
-
// Calls into the HAL interface
// Caller takes ownership of requestTemplate
@@ -300,7 +297,11 @@
status_t configureStreams(const camera_metadata_t *sessionParams,
/*inout*/ camera3_stream_configuration *config,
const std::vector<uint32_t>& bufferSizes);
- status_t processCaptureRequest(camera3_capture_request_t *request);
+
+ // When the call succeeds, the ownership of acquire fences in requests is transferred to
+ // HalInterface. More specifically, the current implementation will send the fence to
+ // HAL process and close the FD in cameraserver process. When the call fails, the ownership
+ // of the acquire fence still belongs to the caller.
status_t processBatchCaptureRequests(
std::vector<camera3_capture_request_t*>& requests,
/*out*/uint32_t* numRequestProcessed);
@@ -895,9 +896,6 @@
// Clear repeating requests. Must be called with mRequestLock held.
status_t clearRepeatingRequestsLocked(/*out*/ int64_t *lastFrameNumber = NULL);
- // send request in mNextRequests to HAL one by one. Return true = sucssess
- bool sendRequestsOneByOne();
-
// send request in mNextRequests to HAL in a batch. Return true = sucssess
bool sendRequestsBatch();