commit 022b52f625036d40d30c0a4172ae70e91fe539dc
author Manisha Jajoo <manisha.jajoo@ittiam.com> Sat Oct 09 00:51:42 2021 +0530
committer Manisha Jajoo <manisha.jajoo@ittiam.com> Thu Oct 06 15:18:15 2022 -0700
tree 5df1bdd5071b89f675b1b568c385434969ce6f16
parent e9cad549ba2b1e42d5e87604e1790fade919770c

MediaMuxer: add wrapper for MediaMuxer constructor

Added MediaMuxer::create(), that validates the input arguments.
All the calls to MediaMuxer's default constructor are now replaced
by MediaMuxer::create().

MediaMuxer's default constructor is still retained as public for the
time being and will be made private in a subsequent CL.

Bug: 146417874
Test: atest CtsMediaV2TestCases:MuxerTest
Test: atest CtsMediaV2TestCases:MuxerUnitTest
Test: CtsMediaMuxerTestCases

Change-Id: I166caa65708cd1ba2076bbbda4c425f534ba2887

services/camera/libcameraservice/api2/HeicCompositeStream.cpp

diff --git a/services/camera/libcameraservice/api2/HeicCompositeStream.cpp b/services/camera/libcameraservice/api2/HeicCompositeStream.cpp
index 54cc27a..71965f2 100644
--- a/services/camera/libcameraservice/api2/HeicCompositeStream.cpp
+++ b/services/camera/libcameraservice/api2/HeicCompositeStream.cpp
@@ -931,7 +931,7 @@
                 tempOutputFile.str().c_str(), errno);
         return NO_INIT;
     }
-    inputFrame.muxer = new MediaMuxer(inputFrame.fileFd, MediaMuxer::OUTPUT_FORMAT_HEIF);
+    inputFrame.muxer = MediaMuxer::create(inputFrame.fileFd, MediaMuxer::OUTPUT_FORMAT_HEIF);
     if (inputFrame.muxer == nullptr) {
         ALOGE("%s: Failed to create MediaMuxer for file fd %d",
                 __FUNCTION__, inputFrame.fileFd);