commit 01df23aa47128de1c8dd92a263cd66ca64a9b70a
author Ray Essick <essick@google.com> Tue Mar 23 22:17:27 2021 -0700
committer Ray Essick <essick@google.com> Tue Mar 23 22:23:59 2021 -0700
tree 183b48823ab00e1d8c3e59f11b8ca31a68603f73
parent 135c989c0c7df54672dd673e54aeede0528d2db6

Add dlclose() to avoid potential leaks

replacement of overly aggressive CHECK() with appropriate loop
continuation didn't dlclose() the no-longer-needed library.

Bug: 182714506
Test: watch logs in special build w/bad extractor
Change-Id: If61e2d0b25d7ac3ababcd18fa4a9f6400678f217

media/libstagefright/MediaExtractorFactory.cpp

diff --git a/media/libstagefright/MediaExtractorFactory.cpp b/media/libstagefright/MediaExtractorFactory.cpp
index d77845f..2520e2a 100644
--- a/media/libstagefright/MediaExtractorFactory.cpp
+++ b/media/libstagefright/MediaExtractorFactory.cpp
@@ -253,6 +253,7 @@
                 (GetExtractorDef) dlsym(libHandle, "GETEXTRACTORDEF");
             if (getDef == nullptr) {
                 ALOGI("no sniffer found in %s", libPath.string());
+                dlclose(libHandle);
                 continue;
             }