commit cfb7d5e3997bb4355027453d9a1e0fd9fbc55637
author Roshan Pius <rpius@google.com> Thu Feb 02 14:36:33 2017 -0800
committer Roshan Pius <rpius@google.com> Thu Feb 02 15:43:00 2017 -0800
tree f07bd8556f78647fe1edb49397b15b4dac4d6839
parent cad6c45da0fded3f6a1fa7d0af4e61bbc65ce7c6

wpa_supplicant(hidl): Add status check for all cb invocation

Bug: 34820508
Test: Compiles
Change-Id: Ic4ed024207711477822aa58cb10720f1f972be80

wpa_supplicant/hidl/hidl_manager.cpp

diff --git a/wpa_supplicant/hidl/hidl_manager.cpp b/wpa_supplicant/hidl/hidl_manager.cpp
index ee257ee..ed91dbf 100644
--- a/wpa_supplicant/hidl/hidl_manager.cpp
+++ b/wpa_supplicant/hidl/hidl_manager.cpp
@@ -279,7 +279,10 @@
 		return;
 	const auto &iface_callback_list = iface_callback_map_iter->second;
 	for (const auto &callback : iface_callback_list) {
-		method(callback);
+		if (!method(callback).isOk()) {
+			wpa_printf(
+			    MSG_ERROR, "Failed to invoke HIDL iface callback");
+		}
 	}
 }
 
@@ -302,7 +305,11 @@
 		return;
 	const auto &network_callback_list = network_callback_map_iter->second;
 	for (const auto &callback : network_callback_list) {
-		method(callback);
+		if (!method(callback).isOk()) {
+			wpa_printf(
+			    MSG_ERROR,
+			    "Failed to invoke HIDL network callback");
+		}
 	}
 }
 
@@ -1583,7 +1590,9 @@
     const std::function<Return<void>(android::sp<ISupplicantCallback>)> &method)
 {
 	for (const auto &callback : supplicant_callbacks_) {
-		method(callback);
+		if (!method(callback).isOk()) {
+			wpa_printf(MSG_ERROR, "Failed to invoke HIDL callback");
+		}
 	}
 }