tree 4626943adf255c2779c9e1497a7ea186fd69384b
parent f3f8d3c8a89ff2b79a8eff5d2a3d94af70847b27
author Hai Shalom <haishalom@google.com> 1614615114 -0800
committer Hai Shalom <haishalom@google.com> 1614615236 -0800

P2P: Fix a corner case in peer addition based on PD Request

p2p_add_device() may remove the oldest entry if there is no room in the
peer table for a new peer. This would result in any pointer to that
removed entry becoming stale. A corner case with an invalid PD Request
frame could result in such a case ending up using (read+write) freed
memory. This could only by triggered when the peer table has reached its
maximum size and the PD Request frame is received from the P2P Device
Address of the oldest remaining entry and the frame has incorrect P2P
Device Address in the payload.

Fix this by fetching the dev pointer again after having called
p2p_add_device() so that the stale pointer cannot be used.

Fixes: 17bef1e97a50 ("P2P: Add peer entry based on Provision Discovery Request")
Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

Bug: 181489537
Test: Compiles

Change-Id: Ief7781491bd545fc1028b9b386fe7a4564102848