tree 5934dfefbc4ce805c0923618834d84248dfae5fa
parent b10c4698bc5484a52acdba27b45c05a18e3cc512
author Hai Shalom <haishalom@google.com> 1614615114 -0800
committer Hai Shalom <haishalom@google.com> 1614632348 +0000

P2P: Fix a corner case in peer addition based on PD Request

p2p_add_device() may remove the oldest entry if there is no room in the
peer table for a new peer. This would result in any pointer to that
removed entry becoming stale. A corner case with an invalid PD Request
frame could result in such a case ending up using (read+write) freed
memory. This could only by triggered when the peer table has reached its
maximum size and the PD Request frame is received from the P2P Device
Address of the oldest remaining entry and the frame has incorrect P2P
Device Address in the payload.

Fix this by fetching the dev pointer again after having called
p2p_add_device() so that the stale pointer cannot be used.

Fixes: 17bef1e97a50 ("P2P: Add peer entry based on Provision Discovery Request")
Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

Bug: 181489537
Test: Compiles

Merged-In: Ief7781491bd545fc1028b9b386fe7a4564102848
(cherry picked from commit c09ec815894987f8c0c65f8ab897b4068020593e)

Change-Id: I7364cbe034c31d99d707600242f01ea2f09bb941