Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 1 | Tests for syntax highlighting plugins |
| 2 | ===================================== |
| 3 | |
| 4 | Summary: Files in the "input" directory are edited by Vim with syntax |
| 5 | highlighting enabled. Screendumps are generated and compared with the |
| 6 | expected screendumps in the "dumps" directory. This will uncover any |
| 7 | character attributes that differ. |
| 8 | |
Aliaksei Budavei | b5a92d7 | 2024-07-07 20:51:14 +0200 | [diff] [blame] | 9 | The dumps are normally 20 screen lines tall. Without any further setup |
| 10 | a screendump is made at the top of the file (using _00.dump) and another |
| 11 | screendump is made if there are more lines (using _01.dump), and so on. |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 12 | |
| 13 | When the screendumps are OK an empty "done/{name}" file is created. This |
| 14 | avoids running the test again until "make clean" is used. Thus you can run |
| 15 | "make test", see one test fail, try to fix the problem, then run "make test" |
| 16 | again to only repeat the failing test. |
| 17 | |
| 18 | When a screendump differs it is stored in the "failed" directory. This allows |
| 19 | for comparing it with the expected screendump, using a command like: |
| 20 | |
Aliaksei Budavei | b5a92d7 | 2024-07-07 20:51:14 +0200 | [diff] [blame] | 21 | let fname = '{name}_00.dump' |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 22 | call term_dumpdiff('failed/' .. fname, 'dumps/' .. fname) |
| 23 | |
| 24 | |
| 25 | Creating a syntax plugin test |
| 26 | ----------------------------- |
| 27 | |
| 28 | Create a source file in the language you want to test in the "input" |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 29 | directory. Use the filetype name as the base and a file name extension |
Aliaksei Budavei | 8418446 | 2024-05-21 01:10:26 +0300 | [diff] [blame] | 30 | matching the filetype. Let's use Java as an example. The file would then be |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 31 | "input/java.java". |
| 32 | |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 33 | Make sure to include some interesting constructs with plenty of complicated |
| 34 | highlighting. Optionally, pre-configure the testing environment by including |
Aliaksei Budavei | 8418446 | 2024-05-21 01:10:26 +0300 | [diff] [blame] | 35 | setup commands at the top of the input file. The format for these lines is: |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 36 | |
Aliaksei Budavei | a2addeb | 2024-03-18 20:39:32 +0100 | [diff] [blame] | 37 | VIM_TEST_SETUP {command} |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 38 | |
| 39 | where {command} is any valid Ex command, which extends to the end of the line. |
| 40 | The first 20 lines of the input file are ALWAYS scanned for setup commands and |
| 41 | these will be executed before the syntax highlighting is enabled. Typically, |
| 42 | these lines would be included as comments so as not to introduce any syntax |
| 43 | errors in the input file but this is not required. |
| 44 | |
| 45 | Continuing the Java example: |
| 46 | |
Aliaksei Budavei | a2addeb | 2024-03-18 20:39:32 +0100 | [diff] [blame] | 47 | // VIM_TEST_SETUP let g:java_space_errors = 1 |
| 48 | // VIM_TEST_SETUP let g:java_minlines = 5 |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 49 | class Test { } |
| 50 | |
Aliaksei Budavei | f6069a7 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 51 | As an alternative, setup commands can be included in an external Vim script |
| 52 | file in the "input/setup" directory. This script file must have the same base |
| 53 | name as the input file. |
| 54 | |
| 55 | So, the equivalent example configuration using this method would be to create |
| 56 | an "input/setup/java.vim" script file with the following lines: |
| 57 | |
| 58 | let g:java_space_errors = 1 |
| 59 | let g:java_minlines = 5 |
| 60 | |
| 61 | Both inline setup commands and setup scripts may be used at the same time, the |
Aliaksei Budavei | a2addeb | 2024-03-18 20:39:32 +0100 | [diff] [blame] | 62 | script file will be sourced before any VIM_TEST_SETUP commands are executed. |
Aliaksei Budavei | f6069a7 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 63 | |
Aliaksei Budavei | 8418446 | 2024-05-21 01:10:26 +0300 | [diff] [blame] | 64 | Every line of a source file must not be longer than 1425 (19 x 75) characters. |
| 65 | |
Aliaksei Budavei | ec02294 | 2024-10-06 16:57:33 +0200 | [diff] [blame] | 66 | If there is no further setup required, you can now run all tests: |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 67 | |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 68 | make test |
| 69 | |
Eisuke Kawashima | 2e18fac | 2025-03-05 21:15:45 +0100 | [diff] [blame] | 70 | Or you can run the tests for a filetype only by passing its name as another |
| 71 | target, e.g. "java", before "test": |
Aliaksei Budavei | ec02294 | 2024-10-06 16:57:33 +0200 | [diff] [blame] | 72 | |
| 73 | make java test |
| 74 | |
| 75 | Or you can run a test or two by passing their filenames as extra targets, e.g. |
| 76 | "java_string.java" and "java_numbers.java", before "test", after listing all |
| 77 | available syntax tests for Java: |
| 78 | |
| 79 | ls testdir/input/java* |
| 80 | make java_string.java java_numbers.java test |
| 81 | |
| 82 | (Some interactive shells may attempt to perform word completion on arbitrary |
| 83 | command arguments when you press certain keys, e.g. Tab or Ctrl-i.) |
| 84 | |
| 85 | As an alternative, you can specify a subset of test filenames for running as |
| 86 | a regular expression and assign it to a VIM_SYNTAX_TEST_FILTER environment |
| 87 | variable; e.g. to run all tests whose base names contain "fold", use any of: |
| 88 | |
| 89 | make test -e 'VIM_SYNTAX_TEST_FILTER = fold.*\..\+' |
| 90 | make test VIM_SYNTAX_TEST_FILTER='fold.*\..\+' |
| 91 | VIM_SYNTAX_TEST_FILTER='fold.*\..\+' make test |
| 92 | |
| 93 | Consider quoting the variable value to avoid any interpretation by the shell. |
| 94 | |
| 95 | Both Make targets and the variable may be used at the same time, the target |
| 96 | names will be tried for matching before the variable value. |
| 97 | |
| 98 | The first time testing "input/java.java" will fail with an error for a missing |
| 99 | screendump. The newly created screendumps will be "failed/java_00.dump", |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 100 | "failed/java_01.dump", etc. You can inspect each with: |
| 101 | |
| 102 | call term_dumpload('failed/java_00.dump') |
| 103 | call term_dumpload('failed/java_01.dump') |
| 104 | ... |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 105 | |
| 106 | If they look OK, move them to the "dumps" directory: |
| 107 | |
| 108 | :!mv failed/java_00.dump dumps |
| 109 | :!mv failed/java_01.dump dumps |
| 110 | ... |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 111 | |
| 112 | If you now run the test again, it will succeed. |
| 113 | |
| 114 | |
| 115 | Adjusting a syntax plugin test |
| 116 | ------------------------------ |
| 117 | |
| 118 | If you make changes to the syntax plugin, you should add code to the input |
| 119 | file to see the effect of these changes. So that the effect of the changes |
Aliaksei Budavei | 7ceca3e | 2025-03-16 20:59:28 +0100 | [diff] [blame] | 120 | is covered by the test. You can follow these steps: |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 121 | |
| 122 | 1. Edit the syntax plugin somewhere in your personal setup. Use a file |
| 123 | somewhere to try out the changes. |
| 124 | 2. Go to the directory where you have the Vim code checked out and replace the |
| 125 | syntax plugin. Run the tests: "make test". Usually the tests will still |
| 126 | pass, but if you fixed syntax highlighting that was already visible in the |
| 127 | input file, carefully check that the changes in the screendump are |
| 128 | intentional: |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 129 | |
Aliaksei Budavei | b5a92d7 | 2024-07-07 20:51:14 +0200 | [diff] [blame] | 130 | let fname = '{name}_00.dump' |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 131 | call term_dumpdiff('failed/' .. fname, 'dumps/' .. fname) |
Aliaksei Budavei | 93edd25 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 132 | |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 133 | Fix the syntax plugin until the result is good. |
| 134 | 2. Edit the input file for your language to add the items you have improved. |
| 135 | (TODO: how to add another screendump?). |
Aliaksei Budavei | 7ceca3e | 2025-03-16 20:59:28 +0100 | [diff] [blame] | 136 | Run the tests and you should get failures. (You may opt for faster failure |
| 137 | by assigning a small number, e.g. "1", to a VIM_SYNTAX_TEST_WAIT_TIME |
| 138 | environment variable and gambling away an "uncertain" possibility of |
| 139 | success.) Like with the previous step, carefully check that the new |
| 140 | screendumps in the "failed" directory are good. Update the syntax plugin |
| 141 | and the input file until the highlighting is good and you can see the |
| 142 | effect of the syntax plugin improvements. Then move the screendumps from |
| 143 | the "failed" to the "dumps" directory. Now "make test" should succeed. |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 144 | 3. Prepare a pull request with the modified files: |
| 145 | - syntax plugin: syntax/{name}.vim |
Aliaksei Budavei | f6069a7 | 2024-03-05 22:34:36 +0300 | [diff] [blame] | 146 | - Vim setup file: syntax/testdir/input/setup/{name}.vim (if any) |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 147 | - test input file: syntax/testdir/input/{name}.{ext} |
Aliaksei Budavei | 7ceca3e | 2025-03-16 20:59:28 +0100 | [diff] [blame] | 148 | - test dump files: syntax/testdir/dumps/{name}_*.dump |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 149 | |
| 150 | As an extra check you can temporarily put back the old syntax plugin and |
| 151 | verify that the tests fail. Then you know your changes are covered by the |
| 152 | test. |
| 153 | |
| 154 | |
Aliaksei Budavei | 6bff6a2 | 2024-08-19 21:33:26 +0200 | [diff] [blame] | 155 | Viewing generated screendumps (local) |
| 156 | ------------------------------------- |
Aliaksei Budavei | d33afe1 | 2024-08-12 18:37:15 +0200 | [diff] [blame] | 157 | |
| 158 | You may also wish to look at the whole batch of failed screendumps after |
| 159 | running "make test". Source the "viewdumps.vim" script for this task: |
| 160 | |
| 161 | [VIMRUNTIME=../..] \ |
| 162 | ../../src/vim --clean -S testdir/viewdumps.vim \ |
| 163 | [testdir/dumps/java_*.dump ...] |
| 164 | |
| 165 | By default, all screendumps found in the "failed" directory will be added to |
| 166 | the argument list and then the first one will be loaded. Loaded screendumps |
| 167 | that bear filenames of screendumps found in the "dumps" directory will be |
| 168 | rendering the contents of any such pair of files and the difference between |
| 169 | them (:help term_dumpdiff()); otherwise, they will be rendering own contents |
| 170 | (:help term_dumpload()). Remember to execute :edit when occasionally you see |
| 171 | raw file contents instead of rendered. |
| 172 | |
| 173 | At any time, you can add, list, and abandon other screendumps: |
| 174 | |
| 175 | :$argedit testdir/dumps/java_*.dump |
| 176 | :args |
| 177 | :qall |
| 178 | |
| 179 | The listing of argument commands can be found under :help buffer-list. |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 180 | |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 181 | |
Aliaksei Budavei | 6bff6a2 | 2024-08-19 21:33:26 +0200 | [diff] [blame] | 182 | Viewing generated screendumps (from a CI-uploaded artifact) |
| 183 | ----------------------------------------------------------- |
| 184 | |
| 185 | After you have downloaded an artifact archive containing failed screendumps |
| 186 | and extracted its files in a temporary directory, you need to set up a "dumps" |
| 187 | directory by creating a symlink: |
| 188 | |
| 189 | cd /path/to/fork |
| 190 | ln -s $(pwd)/runtime/syntax/testdir/dumps \ |
| 191 | /tmp/runtime/syntax/testdir/dumps |
| 192 | |
| 193 | You can now examine the extracted screendumps: |
| 194 | |
| 195 | ./src/vim --clean -S runtime/syntax/testdir/viewdumps.vim \ |
| 196 | /tmp/runtime/syntax/testdir/failed/*.dump |
| 197 | |
| 198 | |
| 199 | Viewing generated screendumps (submitted for a pull request) |
| 200 | ------------------------------------------------------------ |
| 201 | |
Aliaksei Budavei | 5eaacef | 2025-01-11 17:10:06 +0100 | [diff] [blame] | 202 | Note: There is also a "git difftool" extension described in |
| 203 | src/testdir/commondumps.vim |
| 204 | |
Aliaksei Budavei | 6bff6a2 | 2024-08-19 21:33:26 +0200 | [diff] [blame] | 205 | First, you need to check out the topic branch with the proposed changes and |
| 206 | write down a difference list between the HEAD commit (index) and its parent |
| 207 | commit with respect to the changed "dumps" filenames: |
| 208 | |
| 209 | cd /path/to/fork |
| 210 | git switch prs/1234 |
| 211 | git diff-index --relative=runtime/syntax/testdir/dumps/ \ |
| 212 | --name-only prs/1234~1 > /tmp/filelist |
| 213 | |
| 214 | Then, you need to check out the master branch, change the current working |
| 215 | directory to reconcile relative filepaths written in the filenames list, copy |
| 216 | in the "failed" directory the old "dumps" files, whose names are on the same |
| 217 | list, and follow it by checking out the topic branch: |
| 218 | |
| 219 | git switch master |
| 220 | cd runtime/syntax/testdir/dumps |
| 221 | cp -t ../failed $(cat /tmp/filelist) |
| 222 | git switch prs/1234 |
| 223 | |
| 224 | Make note of any missing new screendumps. Please remember about the |
| 225 | introduced INVERTED relation between "dumps" and "failed", i.e. the files to |
| 226 | be committed are in "dumps" already and their old versions are in "failed". |
| 227 | Therefore, you need to copy the missing new screendumps from "dumps" to |
| 228 | "failed": |
| 229 | |
| 230 | cp -t ../failed foo_10.dump foo_11.dump foo_12.dump |
| 231 | |
| 232 | After you have changed the current working directory to its parent directory, |
| 233 | you can now examine the screendumps from the "failed" directory (note that new |
| 234 | screendumps will be shown with no difference between their versions): |
| 235 | |
| 236 | cd .. |
| 237 | ../../../src/vim --clean -S viewdumps.vim |
| 238 | |
| 239 | |
Bram Moolenaar | 46acad7 | 2023-06-11 19:04:18 +0100 | [diff] [blame] | 240 | TODO: test syncing by jumping around |