patch 9.0.0013: reproducing memory access errors can be difficult
Problem: Reproducing memory access errors can be difficult.
Solution: When testing, copy each line to allocated memory, so that valgrind
can detect accessing memory before and/or after it. Fix uncovered
problems.
diff --git a/src/edit.c b/src/edit.c
index a8e695c..2009be1 100644
--- a/src/edit.c
+++ b/src/edit.c
@@ -5013,7 +5013,7 @@
mch_memmove(newp + col, ptr + i,
curbuf->b_ml.ml_line_len - col - i);
- if (curbuf->b_ml.ml_flags & ML_LINE_DIRTY)
+ if (curbuf->b_ml.ml_flags & (ML_LINE_DIRTY | ML_ALLOCATED))
vim_free(curbuf->b_ml.ml_line_ptr);
curbuf->b_ml.ml_line_ptr = newp;
curbuf->b_ml.ml_line_len -= i;
@@ -5232,10 +5232,10 @@
}
// try to advance to the cursor column
+ validate_virtcol();
temp = 0;
line = ptr = ml_get(lnum);
prev_ptr = ptr;
- validate_virtcol();
while ((colnr_T)temp < curwin->w_virtcol && *ptr != NUL)
{
prev_ptr = ptr;