commit f5d639a8af719eb8ecb141b5c0890627e4d83134
author Dominique Pelle <dominique.pelle@gmail.com> Wed Jan 12 15:24:40 2022 +0000
committer Bram Moolenaar <Bram@vim.org> Wed Jan 12 15:24:40 2022 +0000
tree 2890e8ac277b77edd6cb76464a54ff30af478d3f
parent 5d9826973d9f4c6ffbb5648676bb628660c62906

patch 8.2.4070: using uninitialized memory when reading empty file

Problem:    Using uninitialized memory when reading empty file.
Solution:   Check for empty file before checking for NL. (Dominique Pellé,
            closes #9511)

src/testdir/test_eval_stuff.vim

diff --git a/src/testdir/test_eval_stuff.vim b/src/testdir/test_eval_stuff.vim
index ac9589d..ff6d695 100644
--- a/src/testdir/test_eval_stuff.vim
+++ b/src/testdir/test_eval_stuff.vim
@@ -93,6 +93,13 @@
   call delete('XReadfile_bin')
 endfunc
 
+func Test_readfile_binary_empty()
+  call writefile([], 'Xempty-file')
+  " This used to compare uninitialized memory in Vim <= 8.2.4065
+  call assert_equal([''], readfile('Xempty-file', 'b'))
+  call delete('Xempty-file')
+endfunc
+
 func Test_readfile_bom()
   call writefile(["\ufeffFOO", "FOO\ufeffBAR"], 'XReadfile_bom')
   call assert_equal(['FOO', 'FOOBAR'], readfile('XReadfile_bom'))