commit f450804e1438307c79a62053f8c32eef1508383a
author Bram Moolenaar <Bram@vim.org> Sun Jan 15 16:54:57 2023 +0000
committer Bram Moolenaar <Bram@vim.org> Sun Jan 15 16:54:57 2023 +0000
tree 2590180e091fac04509491286afdfb81e47c44f2
parent 4cae845ce32797bcae845aacf740ed865b479f34

patch 9.0.1202: crash when iterating over list of objects

Problem:    Crash when iterating over list of objects.
Solution:   Do not make a copy of tt_member for object or class.
            (closes #11823)

src/testdir/test_vim9_class.vim

diff --git a/src/testdir/test_vim9_class.vim b/src/testdir/test_vim9_class.vim
index 56b2dad..28af68b 100644
--- a/src/testdir/test_vim9_class.vim
+++ b/src/testdir/test_vim9_class.vim
@@ -219,6 +219,27 @@
   v9.CheckScriptSuccess(lines)
 enddef
 
+def Test_list_of_objects()
+  var lines =<< trim END
+      vim9script
+
+      class Foo
+        def Add()
+        enddef
+      endclass
+
+      def ProcessList(fooList: list<Foo>)
+        for foo in fooList
+          foo.Add()
+        endfor
+      enddef
+
+      var l: list<Foo> = [Foo.new()]
+      ProcessList(l)
+  END
+  v9.CheckScriptSuccess(lines)
+enddef
+
 def Test_class_default_new()
   var lines =<< trim END
       vim9script

src/version.c

diff --git a/src/version.c b/src/version.c
index e4674e4..4c9e486 100644
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1202,
+/**/
     1201,
 /**/
     1200,

src/vim9type.c

diff --git a/src/vim9type.c b/src/vim9type.c
index 6fb6b2b..9bb53e2 100644
--- a/src/vim9type.c
+++ b/src/vim9type.c
@@ -86,7 +86,8 @@
     ((type_T **)seen_types->ga_data)[seen_types->ga_len * 2 + 1] = copy;
     ++seen_types->ga_len;
 
-    if (copy->tt_member != NULL)
+    if (copy->tt_member != NULL
+	    && copy->tt_type != VAR_OBJECT && copy->tt_type != VAR_CLASS)
 	copy->tt_member = copy_type_deep_rec(copy->tt_member,
 							 type_gap, seen_types);