patch 9.0.0949: crash when unletting a variable while listing variables
Problem: Crash when unletting a variable while listing variables.
Solution: Disallow changing a hashtable while going over the entries.
(closes #11435)
diff --git a/src/if_lua.c b/src/if_lua.c
index 4900534..78bc190 100644
--- a/src/if_lua.c
+++ b/src/if_lua.c
@@ -1150,7 +1150,7 @@
if (lua_isnil(L, 3)) // remove?
{
hashitem_T *hi = hash_find(&d->dv_hashtab, di->di_key);
- hash_remove(&d->dv_hashtab, hi);
+ hash_remove(&d->dv_hashtab, hi, "Lua new index");
dictitem_free(di);
}
else
@@ -1838,9 +1838,8 @@
if (di == NULL)
// Doesn't exist, nothing to do
return 0;
- else
- // Delete the entry
- dictitem_remove(dict, di);
+ // Delete the entry
+ dictitem_remove(dict, di, "Lua delete variable");
}
else
{