commit ede35bbbd05306097bf3f4d603f2248ed1f4c5f1
author Bram Moolenaar <Bram@vim.org> Fri Jan 26 20:05:18 2018 +0100
committer Bram Moolenaar <Bram@vim.org> Fri Jan 26 20:05:18 2018 +0100
tree ff44a67b6a936ad141146d4553059f1a1cc4d673
parent 200ea8ffaa90e1ccc156b24ee097be87acdd5214

patch 8.0.1429: crash when calling term_start() with empty argument

Problem:    Crash when calling term_start() with empty argument.
Solution:   Check for invalid argument. (Yasuhiro Matsomoto, closes #2503)
            Fix memory leak.

src/testdir/test_terminal.vim

diff --git a/src/testdir/test_terminal.vim b/src/testdir/test_terminal.vim
index cb04edf..3116b80 100644
--- a/src/testdir/test_terminal.vim
+++ b/src/testdir/test_terminal.vim
@@ -795,3 +795,14 @@
   au! repro
   delfunc Nop
 endfunc
+
+func Test_terminal_term_start_empty_command()
+  let cmd = "call term_start('', {'curwin' : 1, 'term_finish' : 'close'})"
+  call assert_fails(cmd, 'E474')
+  let cmd = "call term_start('', {'curwin' : 1, 'term_finish' : 'close'})"
+  call assert_fails(cmd, 'E474')
+  let cmd = "call term_start({}, {'curwin' : 1, 'term_finish' : 'close'})"
+  call assert_fails(cmd, 'E474')
+  let cmd = "call term_start(0, {'curwin' : 1, 'term_finish' : 'close'})"
+  call assert_fails(cmd, 'E474')
+endfunc