patch 8.2.3331: Coverity warns for using value without boundary check
Problem: Coverity warns for using value without boundary check.
Solution: Add a boundary check.
diff --git a/src/viminfo.c b/src/viminfo.c
index 1d3bac1..530346f 100644
--- a/src/viminfo.c
+++ b/src/viminfo.c
@@ -253,17 +253,18 @@
int off, // offset for virp->vir_line
int convert UNUSED) // convert the string
{
- char_u *retval;
+ char_u *retval = NULL;
char_u *s, *d;
long len;
if (virp->vir_line[off] == Ctrl_V && vim_isdigit(virp->vir_line[off + 1]))
{
len = atol((char *)virp->vir_line + off + 1);
- retval = lalloc(len, TRUE);
+ if (len > 0 && len < 1000000)
+ retval = lalloc(len, TRUE);
if (retval == NULL)
{
- // Line too long? File messed up? Skip next line.
+ // Invalid length, line too long, out of memory? Skip next line.
(void)vim_fgets(virp->vir_line, 10, virp->vir_fd);
return NULL;
}