patch 8.2.2783: duplicate code for setting byte in blob, blob test may fail
Problem: Duplicate code for setting byte in blob, blob test may fail.
Solution: Call blob_set_append(). Test sort failure with "N".
diff --git a/src/eval.c b/src/eval.c
index f8e922f..4dbbc40 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -1321,21 +1321,7 @@
{
val = (int)tv_get_number_chk(rettv, &error);
if (!error)
- {
- garray_T *gap = &lp->ll_blob->bv_ga;
-
- // Allow for appending a byte. Setting a byte beyond
- // the end is an error otherwise.
- if (lp->ll_n1 < gap->ga_len
- || (lp->ll_n1 == gap->ga_len
- && ga_grow(&lp->ll_blob->bv_ga, 1) == OK))
- {
- blob_set(lp->ll_blob, lp->ll_n1, val);
- if (lp->ll_n1 == gap->ga_len)
- ++gap->ga_len;
- }
- // error for invalid range was already given in get_lval()
- }
+ blob_set_append(lp->ll_blob, lp->ll_n1, val);
}
}
else if (op != NULL && *op != '=')