commit e3a529bc877909a9eccf792461050b4f6737ed33
author zeertzjq <zeertzjq@outlook.com> Sun Jun 05 19:01:37 2022 +0100
committer Bram Moolenaar <Bram@vim.org> Sun Jun 05 19:01:37 2022 +0100
tree ad3718402e376ba7ff5a21e7761e8719cbab0dc1
parent 6574577cacd393ab7591fc776ea060eebc939e55

patch 8.2.5058: input() does not handle composing characters properly

Problem:    input() does not handle composing characters properly.
Solution:   Use mb_cptr2char_adv() instead of mb_ptr2char_adv().
            (closes #10527)

src/getchar.c

diff --git a/src/getchar.c b/src/getchar.c
index 55fad1c..03d90ac 100644
--- a/src/getchar.c
+++ b/src/getchar.c
@@ -669,7 +669,7 @@
 	}
 	else
 	{
-	    c = mb_ptr2char_adv(&s);
+	    c = mb_cptr2char_adv(&s);
 	    if (c == CAR || c == NL || c == ESC)
 		c = ' ';
 	    stuffcharReadbuff(c);

src/testdir/test_functions.vim

diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim
index af07a64..f55e846 100644
--- a/src/testdir/test_functions.vim
+++ b/src/testdir/test_functions.vim
@@ -1545,6 +1545,10 @@
   call feedkeys(":let c = input('name? ', \"x\\<BS>y\")\<CR>\<CR>", 'xt')
   call assert_equal('y', c)
 
+  " Test for using text with composing characters as default input
+  call feedkeys(":let c = input('name? ', \"ã̳\")\<CR>\<CR>", 'xt')
+  call assert_equal('ã̳', c)
+
   " Test for using <CR> as default input
   call feedkeys(":let c = input('name? ', \"\\<CR>\")\<CR>x\<CR>", 'xt')
   call assert_equal(' x', c)

src/version.c

diff --git a/src/version.c b/src/version.c
index 254b5f1..744fad6 100644
--- a/src/version.c
+++ b/src/version.c
@@ -735,6 +735,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    5058,
+/**/
     5057,
 /**/
     5056,