commit e1121b139480f53d1b06f84f3e4574048108fa0b
author Pavel Mayorov <pmayorov@cloudlinux.com> Mon Feb 20 14:35:20 2023 +0000
committer Bram Moolenaar <Bram@vim.org> Mon Feb 20 14:35:20 2023 +0000
tree 7c95e52cbc3b8972a7b5677fbfd53c630c6538ad
parent af93691b53f38784efce0b93fe7644c44a7e382e

patch 9.0.1331: illegal memory access when using :ball in Visual mode

Problem:    Illegal memory access when using :ball in Visual mode.
Solution:   Stop Visual mode when using :ball. (Pavel Mayorov, closes #11923)

src/buffer.c

diff --git a/src/buffer.c b/src/buffer.c
index cb7bdf4..ff35729 100644
--- a/src/buffer.c
+++ b/src/buffer.c
@@ -5402,6 +5402,10 @@
     else
 	all = TRUE;
 
+    // Stop Visual mode, the cursor and "VIsual" may very well be invalid after
+    // switching to another buffer.
+    reset_VIsual_and_resel();
+
     setpcmark();
 
 #ifdef FEAT_GUI

src/testdir/test_visual.vim

diff --git a/src/testdir/test_visual.vim b/src/testdir/test_visual.vim
index 295e16f..f152e7b 100644
--- a/src/testdir/test_visual.vim
+++ b/src/testdir/test_visual.vim
@@ -1534,4 +1534,25 @@
   exe 'bwipe!' buf2
 endfunc
 
+" Check fix for the heap-based buffer overflow bug found in the function
+" utfc_ptr2len and reported at
+" https://huntr.dev/bounties/ae933869-a1ec-402a-bbea-d51764c6618e
+func Test_heap_buffer_overflow()
+  enew
+  set updatecount=0
+
+  norm R0
+  split other
+  norm R000
+  exe "norm \<C-V>l"
+  ball
+  call assert_equal(getpos("."), getpos("v"))
+  call assert_equal('n', mode())
+  norm zW
+
+  %bwipe!
+  set updatecount&
+endfunc
+
+
 " vim: shiftwidth=2 sts=2 expandtab

src/version.c

diff --git a/src/version.c b/src/version.c
index 63fd787..4c12823 100644
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1331,
+/**/
     1330,
 /**/
     1329,